linux-kernel - Re: linux-next: Tree for Jul 27 (kernel/bpf/syscall.o)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAEf4BzYD-PiA2cDvD5qRv7hHZ_GTDdKqAm1jfg2ZWBWM_3YO5w@mail.gmail.com>
Date:   Mon, 27 Jul 2020 22:48:05 -0700
From:   Andrii Nakryiko <andrii.nakryiko@...il.com>
To:     Randy Dunlap <rdunlap@...radead.org>
Cc:     Stephen Rothwell <sfr@...b.auug.org.au>,
        Linux Next Mailing List <linux-next@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        bpf <bpf@...r.kernel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>
Subject: Re: linux-next: Tree for Jul 27 (kernel/bpf/syscall.o)

On Mon, Jul 27, 2020 at 11:58 AM Randy Dunlap <rdunlap@...radead.org> wrote:
>
> On 7/27/20 6:23 AM, Stephen Rothwell wrote:
> > Hi all,
> >
> > Changes since 20200724:
> >
>
> on i386:
> when CONFIG_XPS is not set/enabled:
>
> ld: kernel/bpf/syscall.o: in function `__do_sys_bpf':
> syscall.c:(.text+0x4482): undefined reference to `bpf_xdp_link_attach'
>

I can't repro this on x86-64 with CONFIG_XPS unset. Do you mind
sharing the exact config you've used?

I see that kernel/bpf/syscall.c doesn't include linux/netdevice.h
directly, so something must be preventing netdevice.h to eventually
get to bpf/syscall.c, but instead of guessing on the fix, I'd like to
repro it first. Thanks!


>
> --
> ~Randy
> Reported-by: Randy Dunlap <rdunlap@...radead.org>