linux-kernel - Re: linux-next: Tree for Jul 27 (drivers/gpu/drm/xlnx/zynqmp-dpsub)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9122c7ca-86a6-1def-0ddc-536ba97b49b8@infradead.org>
Date:   Mon, 27 Jul 2020 17:49:41 -0700
From:   Randy Dunlap <rdunlap@...radead.org>
To:     Stephen Rothwell <sfr@...b.auug.org.au>,
        Linux Next Mailing List <linux-next@...r.kernel.org>
Cc:     Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Hyun Kwon <hyun.kwon@...inx.com>,
        Laurent Pinchart <laurent.pinchart@...asonboard.com>,
        dri-devel <dri-devel@...ts.freedesktop.org>
Subject: Re: linux-next: Tree for Jul 27 (drivers/gpu/drm/xlnx/zynqmp-dpsub)

On 7/27/20 6:23 AM, Stephen Rothwell wrote:
> Hi all,
> 
> Changes since 20200724:
> 

on x86_64:

WARNING: unmet direct dependencies detected for DMA_ENGINE
  Depends on [n]: DMADEVICES [=n]
  Selected by [m]:
  - DRM_ZYNQMP_DPSUB [=m] && HAS_IOMEM [=y] && (ARCH_ZYNQMP || COMPILE_TEST [=y]) && COMMON_CLK [=y] && DRM [=m] && OF [=y]

and about 45 "undefined reference" build errors (here's a sample):

ld: drivers/misc/mic/scif/scif_dma.o: in function `scif_sync_dma.constprop.11':
scif_dma.c:(.text+0x672): undefined reference to `dma_sync_wait'
ld: drivers/spi/spi-bcm2835.o: in function `bcm2835_dma_release.isra.9':
spi-bcm2835.c:(.text+0xb34): undefined reference to `dma_release_channel'
ld: spi-bcm2835.c:(.text+0xc17): undefined reference to `dma_release_channel'
ld: drivers/spi/spi-bcm2835.o: in function `bcm2835_dma_init':
spi-bcm2835.c:(.text+0xd3c): undefined reference to `dma_request_chan'
ld: spi-bcm2835.c:(.text+0xd8b): undefined reference to `dma_request_chan'
ld: spi-bcm2835.c:(.text+0xf8a): undefined reference to `dma_get_slave_caps'
ld: spi-bcm2835.c:(.text+0x11d0): undefined reference to `dma_get_slave_caps'
ld: drivers/spi/spi-ep93xx.o: in function `ep93xx_spi_release_dma':
spi-ep93xx.c:(.text+0x1fc): undefined reference to `dma_release_channel'
ld: spi-ep93xx.c:(.text+0x220): undefined reference to `dma_release_channel'
ERROR: modpost: "dma_release_channel" [drivers/gpu/drm/xlnx/zynqmp-dpsub.ko] undefined!

I tried adding
	depends on DMADEVICES
to DRM_ZYNQMP_DPSUB

but that just gets into messy/ugly Kconfig
	error: recursive dependency detected!

BTW, adding
	select DMADEVICES
is not a good solution.  We try very hard not to enable entire
subsystems with one driver "select".  (No doubt you can find a
few examples that do just that, but it is strongly discouraged.)

Full randconfig file is attached.

thanks.
-- 
~Randy
Reported-by: Randy Dunlap <rdunlap@...radead.org>

View attachment "config-r4192" of type "text/plain" (163728 bytes)