linux-kernel - Re: [PATCH v4 2/2] MIPS: ingenic: Enable JZ4780

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 28 Jul 2020 13:12:11 +0200
From:   Paul Cercueil <paul@...pouillou.net>
To:     Krzysztof Kozlowski <krzk@...nel.org>
Cc:     Thomas Bogendoerfer <tsbogend@...ha.franken.de>,
        "H. Nikolaus Schaller" <hns@...delico.com>,
        linux-mips@...r.kernel.org, linux-kernel@...r.kernel.org,
        Arnd Bergmann <arnd@...db.de>
Subject: Re: [PATCH v4 2/2] MIPS: ingenic: Enable JZ4780_NEMC manually

Hi Krzysztof,

Le mar. 28 juil. 2020 à 12:45, Krzysztof Kozlowski <krzk@...nel.org> a 
écrit :
> The CONFIG_JZ4780_NEMC was previously a default on MIPS but now it has
> to be enabled manually.
> 
> Signed-off-by: Krzysztof Kozlowski <krzk@...nel.org>

I think you should swap the two so that there are no problems when 
bisecting.

With that:
Reviewed-by: Paul Cercueil <paul@...pouillou.net>

Cheers,
-Paul

> 
> ---
> 
> Changes since v3:
> 1. New patch
> ---
>  arch/mips/configs/ci20_defconfig    | 1 +
>  arch/mips/configs/qi_lb60_defconfig | 1 +
>  arch/mips/configs/rs90_defconfig    | 1 +
>  3 files changed, 3 insertions(+)
> 
> diff --git a/arch/mips/configs/ci20_defconfig 
> b/arch/mips/configs/ci20_defconfig
> index e511fe0243a5..0a46199fdc3f 100644
> --- a/arch/mips/configs/ci20_defconfig
> +++ b/arch/mips/configs/ci20_defconfig
> @@ -128,6 +128,7 @@ CONFIG_DMA_JZ4780=y
>  CONFIG_INGENIC_OST=y
>  # CONFIG_IOMMU_SUPPORT is not set
>  CONFIG_MEMORY=y
> +CONFIG_JZ4780_NEMC=y
>  CONFIG_PWM=y
>  CONFIG_PWM_JZ4740=m
>  CONFIG_EXT4_FS=y
> diff --git a/arch/mips/configs/qi_lb60_defconfig 
> b/arch/mips/configs/qi_lb60_defconfig
> index 97c9a69d1528..81bfbee72b0c 100644
> --- a/arch/mips/configs/qi_lb60_defconfig
> +++ b/arch/mips/configs/qi_lb60_defconfig
> @@ -108,6 +108,7 @@ CONFIG_RTC_DRV_JZ4740=y
>  CONFIG_DMADEVICES=y
>  CONFIG_DMA_JZ4780=y
>  CONFIG_MEMORY=y
> +CONFIG_JZ4780_NEMC=y
>  CONFIG_IIO=y
>  CONFIG_INGENIC_ADC=y
>  CONFIG_PWM=y
> diff --git a/arch/mips/configs/rs90_defconfig 
> b/arch/mips/configs/rs90_defconfig
> index 433ac5c0266a..de6752051ecc 100644
> --- a/arch/mips/configs/rs90_defconfig
> +++ b/arch/mips/configs/rs90_defconfig
> @@ -145,6 +145,7 @@ CONFIG_DMA_JZ4780=y
>  CONFIG_INGENIC_OST=y
>  # CONFIG_IOMMU_SUPPORT is not set
>  CONFIG_MEMORY=y
> +CONFIG_JZ4780_NEMC=y
>  CONFIG_IIO=y
>  CONFIG_INGENIC_ADC=y
>  CONFIG_IIO_RESCALE=y
> --
> 2.17.1
>