linux-kernel - Re: [PATCH 0/2] Small cleanups to ingenic-drm driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <PYF7EQ.CC652MXUV2R41@crapouillou.net>
Date:   Wed, 29 Jul 2020 02:28:01 +0200
From:   Paul Cercueil <paul@...pouillou.net>
To:     daniel@...ll.ch
Cc:     David Airlie <airlied@...ux.ie>, od@...c.me,
        linux-kernel@...r.kernel.org, dri-devel@...ts.freedesktop.org
Subject: Re: [PATCH 0/2] Small cleanups to ingenic-drm driver



Le mer. 29 juil. 2020 à 0:00, daniel@...ll.ch a écrit :
> On Tue, Jul 28, 2020 at 10:17:36PM +0200, Sam Ravnborg wrote:
>>  Hi Paul.
>> 
>>  On Tue, Jul 28, 2020 at 05:16:39PM +0200, Paul Cercueil wrote:
>>  > Here are a few cleanups to the ingenic-drm driver.
>>  > - some error paths were missing and have been added;
>>  > - the mode validation has been moved to the .mode_valid helper 
>> callback.
>>  >
>>  > Cheers,
>>  > -Paul
>>  >
>>  > Paul Cercueil (2):
>>  >   drm/ingenic: Handle errors of drm_atomic_get_plane_state
>>  >   drm/ingenic: Validate mode in a .mode_valid callback
>> 
>>  Both looks fine, you can add my:
>>  Reviewed-by: Sam Ravnborg <sam@...nborg.org>
>> 
>>  I assume you will apply the patches.
>>  Maybe wait for Daniel to take a look, he had some feedback on where
>>  to add checks. I assume this is covered by the second patch.
> 
> Yeah changelog for new versions would be great, but aside from that
> bickering patch 2 lgtm now.

This patchset is V1, I'm fixing issues you saw in the ingenic-drm 
driver when reviewing a different patchset.

Thanks for the review, I'll apply now.

-Paul
>