linux-kernel - Re: [PATCH] atm: Fix atm_dev reference count leaks in atmtcp_remove

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <444f9cec-db06-c3b1-eadc-14b11260a4ec@web.de>
Date:   Wed, 29 Jul 2020 19:16:58 +0200
From:   Markus Elfring <Markus.Elfring@....de>
To:     Xin Xiong <xiongx18@...an.edu.cn>,
        Xiyu Yang <xiyuyang19@...an.edu.cn>,
        Xin Tan <tanxin.ctf@...il.com>,
        linux-atm-general@...ts.sourceforge.net, netdev@...r.kernel.org
Cc:     linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org,
        Chas Williams <3chas3@...il.com>,
        Yuan Zhang <yuanxzhang@...an.edu.cn>
Subject: Re: [PATCH] atm: Fix atm_dev reference count leaks in
 atmtcp_remove_persistent()

…
> The refcount leaks issues occur in two error handling paths.

Can it be nicer to use the term “reference count” for the commit message?


> Fix the issue by …

I suggest to replace this wording by the tag “Fixes”.


…
> +++ b/drivers/atm/atmtcp.c
> @@ -433,9 +433,15 @@  static int atmtcp_remove_persistent(int itf)
>  		return -EMEDIUMTYPE;
>  	}
>  	dev_data = PRIV(dev);
> -	if (!dev_data->persist) return 0;
> +	if (!dev_data->persist) {
> +		atm_dev_put(dev);
> +		return 0;
> +	}
…

I propose to add a jump target for the desired exception handling
in this function implementation.

+	if (!dev_data->persist)
+		goto put_device;


Regards,
Markus