lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 30 Jul 2020 09:35:15 +0200 From: Ilya Leoshkevich <iii@...ux.ibm.com> To: Wang Hai <wanghai38@...wei.com>, hca@...ux.ibm.com, gor@...ux.ibm.com, borntraeger@...ibm.com, colin.king@...onical.com Cc: linux-s390@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH] s390/test_unwind: fix possible memleak in test_unwind() On Thu, 2020-07-30 at 14:36 +0800, Wang Hai wrote: > test_unwind() misses to call kfree(bt) in an error path. > Add the missed function call to fix it. > > Fixes: 0610154650f1 ("s390/test_unwind: print verbose unwinding > results") > Reported-by: Hulk Robot <hulkci@...wei.com> > Signed-off-by: Wang Hai <wanghai38@...wei.com> > --- > arch/s390/lib/test_unwind.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/s390/lib/test_unwind.c > b/arch/s390/lib/test_unwind.c > index 32b7a30b2485..b0b12b46bc57 100644 > --- a/arch/s390/lib/test_unwind.c > +++ b/arch/s390/lib/test_unwind.c > @@ -63,6 +63,7 @@ static noinline int test_unwind(struct task_struct > *task, struct pt_regs *regs, > break; > if (state.reliable && !addr) { > pr_err("unwind state reliable but addr is > 0\n"); > + kfree(bt); > return -EINVAL; > } > sprint_symbol(sym, addr); Looks good to me, thanks! Acked-by: Ilya Leoshkevich <iii@...ux.ibm.com>
Powered by blists - more mailing lists