linux-kernel - Re: [PATCH] s390/test_unwind: fix possible memleak in test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200731115226.GD11581@osiris>
Date:   Fri, 31 Jul 2020 13:52:26 +0200
From:   Heiko Carstens <hca@...ux.ibm.com>
To:     Ilya Leoshkevich <iii@...ux.ibm.com>
Cc:     Wang Hai <wanghai38@...wei.com>, gor@...ux.ibm.com,
        borntraeger@...ibm.com, colin.king@...onical.com,
        linux-s390@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] s390/test_unwind: fix possible memleak in test_unwind()

On Thu, Jul 30, 2020 at 09:35:15AM +0200, Ilya Leoshkevich wrote:
> On Thu, 2020-07-30 at 14:36 +0800, Wang Hai wrote:
> > test_unwind() misses to call kfree(bt) in an error path.
> > Add the missed function call to fix it.
> > 
> > Fixes: 0610154650f1 ("s390/test_unwind: print verbose unwinding
> > results")
> > Reported-by: Hulk Robot <hulkci@...wei.com>
> > Signed-off-by: Wang Hai <wanghai38@...wei.com>
> > ---
> >  arch/s390/lib/test_unwind.c | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/arch/s390/lib/test_unwind.c
> > b/arch/s390/lib/test_unwind.c
> > index 32b7a30b2485..b0b12b46bc57 100644
> > --- a/arch/s390/lib/test_unwind.c
> > +++ b/arch/s390/lib/test_unwind.c
> > @@ -63,6 +63,7 @@ static noinline int test_unwind(struct task_struct
> > *task, struct pt_regs *regs,
> >  			break;
> >  		if (state.reliable && !addr) {
> >  			pr_err("unwind state reliable but addr is
> > 0\n");
> > +			kfree(bt);
> >  			return -EINVAL;
> >  		}
> >  		sprint_symbol(sym, addr);
> 
> Looks good to me, thanks!
> 
> Acked-by: Ilya Leoshkevich <iii@...ux.ibm.com>

Applied, thanks!