linux-kernel - Re: [PATCH v2 06/10] gpio: dwapb: Discard GPIO-to-IRQ mapping function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200730142655.GN3703480@smile.fi.intel.com>
Date:   Thu, 30 Jul 2020 17:26:55 +0300
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Serge Semin <Sergey.Semin@...kalelectronics.ru>
Cc:     Hoan Tran <hoan@...amperecomputing.com>,
        Linus Walleij <linus.walleij@...aro.org>,
        Bartosz Golaszewski <bgolaszewski@...libre.com>,
        Serge Semin <fancer.lancer@...il.com>,
        Alexey Malahov <Alexey.Malahov@...kalelectronics.ru>,
        Pavel Parkhomenko <Pavel.Parkhomenko@...kalelectronics.ru>,
        Rob Herring <robh+dt@...nel.org>, linux-gpio@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 06/10] gpio: dwapb: Discard GPIO-to-IRQ mapping
 function

On Thu, Jul 30, 2020 at 04:55:32PM +0300, Serge Semin wrote:
> Since GPIOlib-based IRQ-chip interface is now utilized there is no need in
> setting up a custom GPIO-to-IRQ mapping method. GPIO-lib defines the
> standard mapping method - gpiochip_to_irq(), which will be used anyway no
> matter whether the custom to_irq callback is specified or not.

Reviewed-by: Andy Shevchenko <andy.shevchenko@...il.com>

> Signed-off-by: Serge Semin <fancer.lancer@...il.com>
> 
> ---
> 
> Changelog v2:
> - This is a new patch detached from commit
>   "gpio: dwapb: Convert driver to using the GPIO-lib-based IRQ-chip".
> ---
>  drivers/gpio/gpio-dwapb.c | 10 ----------
>  1 file changed, 10 deletions(-)
> 
> diff --git a/drivers/gpio/gpio-dwapb.c b/drivers/gpio/gpio-dwapb.c
> index 327333fbc750..f7acc5abbf5c 100644
> --- a/drivers/gpio/gpio-dwapb.c
> +++ b/drivers/gpio/gpio-dwapb.c
> @@ -150,14 +150,6 @@ static inline void dwapb_write(struct dwapb_gpio *gpio, unsigned int offset,
>  	gc->write_reg(reg_base + gpio_reg_convert(gpio, offset), val);
>  }
>  
> -static int dwapb_gpio_to_irq(struct gpio_chip *gc, unsigned offset)
> -{
> -	struct dwapb_gpio_port *port = gpiochip_get_data(gc);
> -	struct dwapb_gpio *gpio = port->gpio;
> -
> -	return irq_find_mapping(gpio->domain, offset);
> -}
> -
>  static struct dwapb_gpio_port *dwapb_offs_to_port(struct dwapb_gpio *gpio, unsigned int offs)
>  {
>  	struct dwapb_gpio_port *port;
> @@ -466,8 +458,6 @@ static void dwapb_configure_irqs(struct dwapb_gpio *gpio,
>  	}
>  
>  	girq->chip = &port->irqchip;
> -
> -	port->gc.to_irq = dwapb_gpio_to_irq;
>  }
>  
>  static int dwapb_gpio_add_port(struct dwapb_gpio *gpio,
> -- 
> 2.27.0
> 

-- 
With Best Regards,
Andy Shevchenko