linux-kernel - Re: [PATCH v2 07/10] gpio: dwapb: Discard ACPI GPIO-chip IRQs request

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200730142715.GO3703480@smile.fi.intel.com>
Date:   Thu, 30 Jul 2020 17:27:15 +0300
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Serge Semin <Sergey.Semin@...kalelectronics.ru>
Cc:     Hoan Tran <hoan@...amperecomputing.com>,
        Linus Walleij <linus.walleij@...aro.org>,
        Bartosz Golaszewski <bgolaszewski@...libre.com>,
        Serge Semin <fancer.lancer@...il.com>,
        Alexey Malahov <Alexey.Malahov@...kalelectronics.ru>,
        Pavel Parkhomenko <Pavel.Parkhomenko@...kalelectronics.ru>,
        Rob Herring <robh+dt@...nel.org>, linux-gpio@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 07/10] gpio: dwapb: Discard ACPI GPIO-chip IRQs request

On Thu, Jul 30, 2020 at 04:55:33PM +0300, Serge Semin wrote:
> Since GPIOlib-based IRQ-chip interface is now utilized there is no need
> in calling the methods acpi_gpiochip_{request,free}_interrupts() here.
> They will be called from gpiochip_add_irqchip()/gpiochip_irqchip_remove()
> anyway.

Reviewed-by: Andy Shevchenko <andy.shevchenko@...il.com>

> Signed-off-by: Serge Semin <fancer.lancer@...il.com>
> 
> ---
> 
> Changelog v2:
> - This is a new patch detached from commit
>   "gpio: dwapb: Convert driver to using the GPIO-lib-based IRQ-chip".
> ---
>  drivers/gpio/gpio-dwapb.c | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/drivers/gpio/gpio-dwapb.c b/drivers/gpio/gpio-dwapb.c
> index f7acc5abbf5c..226d9c2d9493 100644
> --- a/drivers/gpio/gpio-dwapb.c
> +++ b/drivers/gpio/gpio-dwapb.c
> @@ -512,9 +512,6 @@ static int dwapb_gpio_add_port(struct dwapb_gpio *gpio,
>  		return err;
>  	}
>  
> -	/* Add GPIO-signaled ACPI event support */
> -	acpi_gpiochip_request_interrupts(&port->gc);
> -
>  	port->is_registered = true;
>  
>  	return 0;
> @@ -530,7 +527,6 @@ static void dwapb_gpio_unregister(struct dwapb_gpio *gpio)
>  		if (!port->is_registered)
>  			continue;
>  
> -		acpi_gpiochip_free_interrupts(&port->gc);
>  		gpiochip_remove(&port->gc);
>  	}
>  }
> -- 
> 2.27.0
> 

-- 
With Best Regards,
Andy Shevchenko