linux-kernel - Re: [Intel-gfx] [PATCH] drm/i915: Fix wrong return value

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <159636908251.23037.6183292610375916917@build.alporthouse.com>
Date:   Sun, 02 Aug 2020 12:51:22 +0100
From:   Chris Wilson <chris@...is-wilson.co.uk>
To:     Andi Shyti <andi.shyti@...el.com>,
        Tianjia Zhang <tianjia.zhang@...ux.alibaba.com>
Cc:     dri-devel@...ts.freedesktop.org, airlied@...ux.ie,
        intel-gfx@...ts.freedesktop.org, linux-kernel@...r.kernel.org,
        tianjia.zhang@...baba.com, matthew.auld@...el.com
Subject: Re: [Intel-gfx] [PATCH] drm/i915: Fix wrong return value

Quoting Andi Shyti (2020-08-02 12:40:44)
> Hi Tianjia,
> 
> > diff --git a/drivers/gpu/drm/i915/i915_active.c b/drivers/gpu/drm/i915/i915_active.c
> > index d960d0be5bd2..cc017e3cc9c5 100644
> > --- a/drivers/gpu/drm/i915/i915_active.c
> > +++ b/drivers/gpu/drm/i915/i915_active.c
> > @@ -758,7 +758,7 @@ int i915_active_acquire_preallocate_barrier(struct i915_active *ref,
> >       intel_engine_mask_t tmp, mask = engine->mask;
> >       struct llist_node *first = NULL, *last = NULL;
> >       struct intel_gt *gt = engine->gt;
> > -     int err;
> > +     int err = 0;
> 
> you don't need the initialization here.

But it's close enough that I can munge the patch inline.
Reviewed-by: Chris Wilson <chris@...is-wilson.co.uk>
-Chris