linux-kernel - Re: [PATCH] nvme-fc: Fix wrong return value in __nvme_fc_init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BYAPR04MB4965A8EF12A48FF2418B6D92864C0@BYAPR04MB4965.namprd04.prod.outlook.com>
Date:   Sun, 2 Aug 2020 22:54:48 +0000
From:   Chaitanya Kulkarni <Chaitanya.Kulkarni@....com>
To:     Tianjia Zhang <tianjia.zhang@...ux.alibaba.com>,
        "james.smart@...adcom.com" <james.smart@...adcom.com>,
        "kbusch@...nel.org" <kbusch@...nel.org>,
        "axboe@...com" <axboe@...com>, "hch@....de" <hch@....de>,
        "sagi@...mberg.me" <sagi@...mberg.me>,
        "jthumshirn@...e.de" <jthumshirn@...e.de>,
        "james_p_freyensee@...ux.intel.com" 
        <james_p_freyensee@...ux.intel.com>
CC:     "tianjia.zhang@...baba.com" <tianjia.zhang@...baba.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-nvme@...ts.infradead.org" <linux-nvme@...ts.infradead.org>
Subject: Re: [PATCH] nvme-fc: Fix wrong return value in
 __nvme_fc_init_request()

On 8/2/20 04:22, Tianjia Zhang wrote:
> On an error exit path, a negative error code should be returned
> instead of a positive return value.
> 
> Fixes: e399441de9115 ("nvme-fabrics: Add host support for FC transport")
> Cc: James Smart<jsmart2021@...il.com>
> Signed-off-by: Tianjia Zhang<tianjia.zhang@...ux.alibaba.com>

Looks good.

Reviewed-by: Chaitanya Kulkarni <chaitanya.kulkarni@....com>