linux-kernel - Re: [PATCH] nvme-fc: Fix wrong return value in __nvme_fc_init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200814081713.GA18371@infradead.org>
Date:   Fri, 14 Aug 2020 09:17:13 +0100
From:   Christoph Hellwig <hch@...radead.org>
To:     Tianjia Zhang <tianjia.zhang@...ux.alibaba.com>
Cc:     james.smart@...adcom.com, kbusch@...nel.org, axboe@...com,
        hch@....de, sagi@...mberg.me, jthumshirn@...e.de,
        james_p_freyensee@...ux.intel.com, tianjia.zhang@...baba.com,
        linux-kernel@...r.kernel.org, linux-nvme@...ts.infradead.org
Subject: Re: [PATCH] nvme-fc: Fix wrong return value in
 __nvme_fc_init_request()

On Sun, Aug 02, 2020 at 07:15:45PM +0800, Tianjia Zhang wrote:
> On an error exit path, a negative error code should be returned
> instead of a positive return value.
> 
> Fixes: e399441de9115 ("nvme-fabrics: Add host support for FC transport")
> Cc: James Smart <jsmart2021@...il.com>
> Signed-off-by: Tianjia Zhang <tianjia.zhang@...ux.alibaba.com>

Looks good:

Reviewed-by: Christoph Hellwig <hch@....de>