linux-kernel - Re: [PATCH v2 2/2] leds: pca955x: Add an IBM software implementation of the PCA9552 chip

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75VevG65uuE4Vv49tSdvpNnxE7AC7W_QR2s8twCPZ=4da_g@mail.gmail.com>
Date:   Mon, 3 Aug 2020 19:42:17 +0300
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Eddie James <eajames@...ux.ibm.com>
Cc:     Linux LED Subsystem <linux-leds@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        devicetree <devicetree@...r.kernel.org>,
        Rob Herring <robh+dt@...nel.org>, Dan Murphy <dmurphy@...com>,
        Pavel Machek <pavel@....cz>,
        Jacek Anaszewski <jacek.anaszewski@...il.com>,
        vishwa@...ux.ibm.com
Subject: Re: [PATCH v2 2/2] leds: pca955x: Add an IBM software implementation
 of the PCA9552 chip

On Mon, Aug 3, 2020 at 5:51 PM Eddie James <eajames@...ux.ibm.com> wrote:
>
> IBM created an implementation of the PCA9552 on a PIC16F
> microcontroller. The I2C device addresses are different from the
> hardware PCA9552, so add a new compatible string and associated
> platform data to be able to probe this device.

...

>         pca9550,
>         pca9551,
>         pca9552,
> +       ibm_pca9552,
>         pca9553,

I would rather not mix like this, but use alpha order, for example.
It's better to read and see which devices are supported by vendor.

...

>         },

> +       [ibm_pca9552] = {

> +       },
>         [pca9553] = {

Ditto.

...

>         { "pca9550", pca9550 },
>         { "pca9551", pca9551 },
>         { "pca9552", pca9552 },
> +       { "ibm-pca9552", ibm_pca9552 },
>         { "pca9553", pca9553 },

Ditto.

...

>         { .compatible = "nxp,pca9550", .data = (void *)pca9550 },
>         { .compatible = "nxp,pca9551", .data = (void *)pca9551 },
>         { .compatible = "nxp,pca9552", .data = (void *)pca9552 },
> +       { .compatible = "ibm,pca9552", .data = (void *)ibm_pca9552 },
>         { .compatible = "nxp,pca9553", .data = (void *)pca9553 },

Ditto.

-- 
With Best Regards,
Andy Shevchenko