linux-kernel - Re: [PATCH v4 4/6] can: ctucanfd: CTU CAN FD open-source IP core

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e4378bd9-6484-88bc-48d3-d7fdda62c844@infradead.org>
Date:   Mon, 3 Aug 2020 12:32:11 -0700
From:   Randy Dunlap <rdunlap@...radead.org>
To:     pisa@....felk.cvut.cz, linux-can@...r.kernel.org,
        devicetree@...r.kernel.org, mkl@...gutronix.de,
        socketcan@...tkopp.net
Cc:     wg@...ndegger.com, davem@...emloft.net, robh+dt@...nel.org,
        mark.rutland@....com, c.emde@...dl.org, armbru@...hat.com,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        martin.jerabek01@...il.com, ondrej.ille@...il.com,
        jnovak@....cvut.cz, jara.beran@...il.com, porazil@...ron.com
Subject: Re: [PATCH v4 4/6] can: ctucanfd: CTU CAN FD open-source IP core -
 PCI bus support.

On 8/3/20 11:34 AM, pisa@....felk.cvut.cz wrote:
> diff --git a/drivers/net/can/ctucanfd/Kconfig b/drivers/net/can/ctucanfd/Kconfig
> index 0620111d57fd..8a5f5d05fa72 100644
> --- a/drivers/net/can/ctucanfd/Kconfig
> +++ b/drivers/net/can/ctucanfd/Kconfig
> @@ -15,4 +15,13 @@ config CAN_CTUCANFD
>  
>  if CAN_CTUCANFD
>  
> +config CAN_CTUCANFD_PCI
> +    tristate "CTU CAN-FD IP core PCI/PCIe driver"
> +    depends on PCI
> +	help

"help" should be indented with one tab only (no spaces).

> +	  This driver adds PCI/PCIe support for CTU CAN-FD IP core.
> +	  The project providing FPGA design for Intel EP4CGX15 based DB4CGX15
> +	  PCIe board with PiKRON.com designed transceiver riser shield is available
> +	  at https://gitlab.fel.cvut.cz/canbus/pcie-ctu_can_fd .

help text should be indented with one tab + 2 spaces according to
Documentation/process/coding-style.rst.

> +
>  endif

thanks.
-- 
~Randy