linux-kernel - Re: [PATCH v4 0/6] CTU CAN FD open-source IP core SocketCAN driver, PCI, platform integration and documentation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200803132949.64884ff1@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Mon, 3 Aug 2020 13:29:49 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     pisa@....felk.cvut.cz
Cc:     linux-can@...r.kernel.org, devicetree@...r.kernel.org,
        mkl@...gutronix.de, socketcan@...tkopp.net, wg@...ndegger.com,
        davem@...emloft.net, robh+dt@...nel.org, mark.rutland@....com,
        c.emde@...dl.org, armbru@...hat.com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, martin.jerabek01@...il.com,
        ondrej.ille@...il.com, jnovak@....cvut.cz, jara.beran@...il.com,
        porazil@...ron.com
Subject: Re: [PATCH v4 0/6] CTU CAN FD open-source IP core SocketCAN driver,
 PCI, platform integration and documentation

On Mon,  3 Aug 2020 20:34:48 +0200 pisa@....felk.cvut.cz wrote:
> From: Pavel Pisa <pisa@....felk.cvut.cz>
> 
> This driver adds support for the CTU CAN FD open-source IP core.
> More documentation and core sources at project page
> (https://gitlab.fel.cvut.cz/canbus/ctucanfd_ip_core).
> The core integration to Xilinx Zynq system as platform driver
> is available (https://gitlab.fel.cvut.cz/canbus/zynq/zynq-can-sja1000-top).
> Implementation on Intel FPGA based PCI Express board is available
> from project (https://gitlab.fel.cvut.cz/canbus/pcie-ctu_can_fd).
> The CTU CAN FD core emulation send for review for QEMU mainline.
> Development repository for QEMU emulation - ctu-canfd branch of
>   https://gitlab.fel.cvut.cz/canbus/qemu-canbus
> 
> More about CAN related projects used and developed at the Faculty
> of the Electrical Engineering (http://www.fel.cvut.cz/en/)
> of Czech Technical University (https://www.cvut.cz/en)
> in Prague at http://canbus.pages.fel.cvut.cz/ .

Patches 3 and 4 have warnings when built with W=1 C=1 flags.

Please also remove the uses of static inline in C sources.
Those are rarely necessary and hide unused code warnings.