lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 3 Aug 2020 01:13:43 +0000 From: Roy Im <roy.im.opensource@...semi.com> To: Pavel Machek <pavel@....cz>, Dmitry Torokhov <dmitry.torokhov@...il.com> CC: Roy Im <roy.im.opensource@...semi.com>, Uwe Kleine-Koenig <u.kleine-koenig@...gutronix.de>, Bartosz Golaszewski <bgolaszewski@...libre.com>, Brian Masney <masneyb@...tation.org>, Greg KH <gregkh@...uxfoundation.org>, Lee Jones <lee.jones@...aro.org>, Luca Weiss <luca@...tu.xyz>, Maximilian Luz <luzmaximilian@...il.com>, Pascal PAILLET-LME <p.paillet@...com>, Rob Herring <robh@...nel.org>, Samuel Ortiz <sameo@...ux.intel.com>, Thierry Reding <thierry.reding@...il.com>, Thomas Gleixner <tglx@...utronix.de>, Support Opensource <Support.Opensource@...semi.com>, "linux-input@...r.kernel.org" <linux-input@...r.kernel.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, "linux-pwm@...r.kernel.org" <linux-pwm@...r.kernel.org> Subject: RE: [PATCH v18 3/3] Input: new da7280 haptic driver On Sun, August 2, 2020 8:54 PM, Pavel Machek wrote: > Hi! > > > > +static DEVICE_ATTR_RW(ps_seq_id); > > > +static DEVICE_ATTR_RW(ps_seq_loop); static > > > +DEVICE_ATTR_RW(gpi_seq_id0); static DEVICE_ATTR_RW(gpi_seq_id1); > > > +static DEVICE_ATTR_RW(gpi_seq_id2); static > > > +DEVICE_ATTR_WO(patterns); > > > > Should this be a binary attribute instead of having string parsing in > > the kernel? > > Plus... is this suitable userland interface? Should it be documetned? It could be used by sysfs interface and string parsing, and I added some examples ahead of id and loop attributes, but for the patterns yes, it should be. As I have already added some comment before for the first comment from Dmitry, now the upload effect covers this attributes, so I would like to remove them and I have added some code a little bit more in the upload effect function in the next patch. Thanks for your comments. > > -- > (english) http://www.livejournal.com/~pavelmachek > (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html Kind regards Roy
Powered by blists - more mailing lists