lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 3 Aug 2020 10:40:56 +0800 From: Neal Liu <neal.liu@...iatek.com> To: "Rafael J. Wysocki" <rafael@...nel.org> CC: Neal Liu <neal.liu@...iatek.com>, "Rafael J. Wysocki" <rjw@...ysocki.net>, Len Brown <lenb@...nel.org>, Daniel Lezcano <daniel.lezcano@...aro.org>, Thierry Reding <thierry.reding@...il.com>, Jonathan Hunter <jonathanh@...dia.com>, Jacob Pan <jacob.jun.pan@...ux.intel.com>, Matthias Brugger <matthias.bgg@...il.com>, Sami Tolvanen <samitolvanen@...gle.com>, ACPI Devel Maling List <linux-acpi@...r.kernel.org>, Linux PM <linux-pm@...r.kernel.org>, linux-tegra <linux-tegra@...r.kernel.org>, Linux ARM <linux-arm-kernel@...ts.infradead.org>, "moderated list:ARM/Mediatek SoC..." <linux-mediatek@...ts.infradead.org>, lkml <linux-kernel@...r.kernel.org>, wsd_upstream <wsd_upstream@...iatek.com> Subject: Re: [PATCH] acpi: fix 'return' with no value build warning On Fri, 2020-07-31 at 13:33 +0200, Rafael J. Wysocki wrote: > On Fri, Jul 31, 2020 at 5:39 AM Neal Liu <neal.liu@...iatek.com> wrote: > > > > Fixing CFI issue which introduced by commit efe9711214e6 is > > incomplete. > > Add return value to fix return-type build warning. > > > > Signed-off-by: Neal Liu <neal.liu@...iatek.com> > > Applied with edited subject and changelog, but -> > > > --- > > drivers/acpi/processor_idle.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/acpi/processor_idle.c b/drivers/acpi/processor_idle.c > > index 6ffb6c9..6870020 100644 > > --- a/drivers/acpi/processor_idle.c > > +++ b/drivers/acpi/processor_idle.c > > @@ -664,11 +664,11 @@ static int acpi_idle_enter_s2idle(struct cpuidle_device *dev, > > struct acpi_processor *pr = __this_cpu_read(processors); > > > > if (unlikely(!pr)) > > - return; > > + return -EFAULT; > > -> there is no point returning an error code here, so I've made it > just return 0. return 0 is not matched with the meaning of contexts, but it's fine for this patch. Thanks ! > > > > > if (pr->flags.bm_check) { > > acpi_idle_enter_bm(pr, cx, false); > > - return; > > + return 0; > > } else { > > ACPI_FLUSH_CPU_CACHE(); > > } > > --
Powered by blists - more mailing lists