linux-kernel - Re: [PATCH 5.7 000/120] 5.7.13-rc1 review

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200804030107.GA220454@roeck-us.net>
Date:   Mon, 3 Aug 2020 20:01:07 -0700
From:   Guenter Roeck <linux@...ck-us.net>
To:     Geert Uytterhoeven <geert@...ux-m68k.org>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        "torvalds@...ux-foundation.org" <torvalds@...ux-foundation.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Shuah Khan <shuah@...nel.org>, patches@...nelci.org,
        Ben Hutchings <ben.hutchings@...ethink.co.uk>,
        lkft-triage@...ts.linaro.org, stable <stable@...r.kernel.org>
Subject: Re: [PATCH 5.7 000/120] 5.7.13-rc1 review

On Mon, Aug 03, 2020 at 10:33:59PM +0200, Geert Uytterhoeven wrote:
> Hi Greg,
> 
> On Mon, Aug 3, 2020 at 7:35 PM Greg Kroah-Hartman
> <gregkh@...uxfoundation.org> wrote:
> > On Mon, Aug 03, 2020 at 08:58:20AM -0700, Guenter Roeck wrote:
> > > On Mon, Aug 03, 2020 at 02:17:38PM +0200, Greg Kroah-Hartman wrote:
> > > > This is the start of the stable review cycle for the 5.7.13 release.  There
> > > > are 120 patches in this series, all will be posted as a response to this one.
> > > > If anyone has any issues with these being applied, please let me know.
> > > >
> > > > Responses should be made by Wed, 05 Aug 2020 12:18:33 +0000.  Anything
> > > > received after that time might be too late.
> > > >
> > >
> > > Building sparc64:allmodconfig ... failed
> > > --------------
> > > Error log:
> > > <stdin>:1511:2: warning: #warning syscall clone3 not implemented [-Wcpp]
> > > In file included from arch/sparc/include/asm/percpu_64.h:11,
> > >                  from arch/sparc/include/asm/percpu.h:5,
> > >                  from include/linux/random.h:14,
> > >                  from fs/crypto/policy.c:13:
> > > arch/sparc/include/asm/trap_block.h:54:39: error: 'NR_CPUS' undeclared here (not in a function)
> > >    54 | extern struct trap_per_cpu trap_block[NR_CPUS];
> > >
> > > Inherited from mainline. Builds are not complete yet;
> > > we may see a few more failures (powerpc:ppc64e_defconfig
> > > fails to build in mainline as well).
> >
> > If it gets fixed upstream, I'll fix it here :)
> 
> And else you'll release a known-broken v5.7.13?
> 
> Perhaps backporting should be a bit less aggressive?
> This breakage was introduced in between v5.8-rc7 and v5.8, and backported
> before people had the time to properly look into the v5.8 build bot logs.
> 

The bisect log below applies to both the sparc and the powerpc build
failures.

I should have guessed. Bisect points to the random changes. Those are
really causing an endless amount of trouble. I hope the problem they
are solving is worth all that trouble.

Guenter

---
# bad: [333e573a423b816b8b28000d6106fa52bd98e198] Linux 4.14.192-rc1
# good: [7f2c5eb458b8855655a19c44cd0043f7f83c595f] Linux 4.14.191
git bisect start 'HEAD' 'v4.14.191'
# bad: [88918f1a1f18dad31154103fa5218e714f10679e] net/x25: Fix x25_neigh refcnt leak when x25 disconnect
git bisect bad 88918f1a1f18dad31154103fa5218e714f10679e
# good: [1f9d268fd05887ecb6225a9452309efc3535492d] ARM: percpu.h: fix build error
git bisect good 1f9d268fd05887ecb6225a9452309efc3535492d
# bad: [f496bedf603212e6dbef88425680f8e137a51e27] random32: remove net_rand_state from the latent entropy gcc plugin
git bisect bad f496bedf603212e6dbef88425680f8e137a51e27
# good: [1e69d85c7e40051b57414953410bcee858285081] f2fs: check memory boundary by insane namelen
git bisect good 1e69d85c7e40051b57414953410bcee858285081
# bad: [0ea865dc4e3d93320e7103958ff041f5d7032ed5] random: fix circular include dependency on arm64 after addition of percpu.h
git bisect bad 0ea865dc4e3d93320e7103958ff041f5d7032ed5
# good: [e2bd43f819d770de686a904b7139bf444e96543c] f2fs: check if file namelen exceeds max value
git bisect good e2bd43f819d770de686a904b7139bf444e96543c
# first bad commit: [0ea865dc4e3d93320e7103958ff041f5d7032ed5] random: fix circular include dependency on arm64 after addition of percpu.h