linux-kernel - Re: [PATCH 5.7 021/120] random32: update the net random state on interrupt and activity

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200804030637.GA16602@1wt.eu>
Date:   Tue, 4 Aug 2020 05:06:37 +0200
From:   Willy Tarreau <w@....eu>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     linux-kernel@...r.kernel.org, stable@...r.kernel.org,
        Amit Klein <aksecurity@...il.com>,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        Eric Dumazet <edumazet@...gle.com>,
        "Jason A. Donenfeld" <Jason@...c4.com>,
        Andy Lutomirski <luto@...nel.org>,
        Kees Cook <keescook@...omium.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Peter Zijlstra <peterz@...radead.org>,
        Stephen Rothwell <sfr@...b.auug.org.au>,
        Michael Ellerman <mpe@...erman.id.au>
Subject: Re: [PATCH 5.7 021/120] random32: update the net random state on
 interrupt and activity

Hi Greg,

On Mon, Aug 03, 2020 at 02:17:59PM +0200, Greg Kroah-Hartman wrote:
> From: Willy Tarreau <w@....eu>
> 
> commit f227e3ec3b5cad859ad15666874405e8c1bbc1d4 upstream.
> 
> This modifies the first 32 bits out of the 128 bits of a random CPU's
> net_rand_state on interrupt or CPU activity to complicate remote
> observations that could lead to guessing the network RNG's internal
> state.
(...)

Stephen reported at least one powerpc build breakage with this one,
and Michael suggested a yet unmerged fix. Thus I'm wondering if we
shouldn't postpone inclusion of these 3 random32 backports to stable
to give some time to stabilize them and avoid breaking setups.

Just my two cents,
Willy