linux-kernel - Re: [PATCH v4 1/4] power: supply: core: add quick charge type property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200804074913.GC1761483@kroah.com>
Date:   Tue, 4 Aug 2020 09:49:13 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     ivan <yanziily@...il.com>
Cc:     Sebastian Reichel <sre@...nel.org>, Pavel Machek <pavel@...x.de>,
        linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org,
        jiangfei1@...omi.com, Qiwu Huang <huangqiwu@...omi.com>
Subject: Re: [PATCH v4 1/4] power: supply: core: add quick charge type
 property

On Tue, Aug 04, 2020 at 10:11:19AM +0800, ivan wrote:
> On Mon, Aug 3, 2020 at 7:57 PM Greg KH <gregkh@...uxfoundation.org> wrote:
> >
> > On Mon, Aug 03, 2020 at 01:49:50PM +0200, Sebastian Reichel wrote:
> > > More importantely I prefer not to merge new APIs without any users
> > > (i.e. a driver making use of those values). Having a reference
> > > driver means, that there is an example how to use the values
> > > correctly and proves it is actually needed upstream. Right now
> > > this looks like "let's modify the upstream kernel, so that we can
> > > easily maintain our out of tree driver".
> >
> > Agreed.  Qiwu, can you also submit your driver so we can see these
> > values be used?
> 
> Our driver is based on qualcomm's driver secondary development.
> 
> The driver code is for mi 10.
> 
> https://github.com/MiCode/Xiaomi_Kernel_OpenSource/blob/umi-q-oss/drivers/power/supply/qcom/qpnp-smb5.c#L1434
> 
> + case POWER_SUPPLY_PROP_QUICK_CHARGE_TYPE:
> +     val->intval = smblib_get_quick_charge_type(chg);
> +     break;
> 
> https://github.com/MiCode/Xiaomi_Kernel_OpenSource/blob/umi-q-oss/drivers/power/supply/qcom/smb5-lib.c#L7713

<snip>

Great, can you submit these drivers as patches as part of this series?
That's the best way for all of this to be integrated.

thanks,

greg k-h