linux-kernel - Re: [PATCH net-next] net: stmmac: fix failed to suspend if phy based WOL is enabled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200803.175959.2039460326230906074.davem@davemloft.net>
Date:   Mon, 03 Aug 2020 17:59:59 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     Jisheng.Zhang@...aptics.com
Cc:     peppe.cavallaro@...com, alexandre.torgue@...com,
        joabreu@...opsys.com, kuba@...nel.org, mcoquelin.stm32@...il.com,
        netdev@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next] net: stmmac: fix failed to suspend if phy
 based WOL is enabled

From: Jisheng Zhang <Jisheng.Zhang@...aptics.com>
Date: Mon, 3 Aug 2020 16:56:47 +0800

> With the latest net-next tree, if test suspend/resume after enabling
> WOL, we get error as below:
> 
> [  487.086365] dpm_run_callback(): mdio_bus_suspend+0x0/0x30 returns -16
> [  487.086375] PM: Device stmmac-0:00 failed to suspend: error -16
> 
> -16 means -EBUSY, this is because I didn't enable wakeup of the correct
> device when implementing phy based WOL feature. To be honest, I caught
> the issue when implementing phy based WOL and then fix it locally, but
> forgot to amend the phy based wol patch. Today, I found the issue by
> testing net-next tree.
> 
> Signed-off-by: Jisheng Zhang <Jisheng.Zhang@...aptics.com>

Applied.