linux-kernel - Re: [PATCH] staging: Add Mediatek High Frequency Manager Framework

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Tue, 4 Aug 2020 18:35:00 +0800
From:   kernel test robot <lkp@...el.com>
To:     "hongxu.zhao" <hongxu.zhao@...iatek.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     kbuild-all@...ts.01.org,
        "open list:STAGING SUBSYSTEM" <devel@...verdev.osuosl.org>,
        wsd_upstream@...iatek.com, Weiqi Fu <weiqi.fu@...iatek.com>,
        Hongxu Zhao <hongxu.zhao@...iatek.com>,
        open list <linux-kernel@...r.kernel.org>,
        Cunliang Du <cunliang.du@...iatek.com>,
        "moderated list:ARM/Mediatek SoC support" 
        <linux-mediatek@...ts.infradead.org>,
        Matthias Brugger <matthias.bgg@...il.com>,
        Zhen jiang <zhen.jiang@...iatek.com>
Subject: Re: [PATCH] staging: Add Mediatek High Frequency Manager Framework

Hi "hongxu.zhao",

Thank you for the patch! Yet something to improve:

[auto build test ERROR on staging/staging-testing]

url:    https://github.com/0day-ci/linux/commits/hongxu-zhao/staging-Add-Mediatek-High-Frequency-Manager-Framework/20200804-155814
base:   https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git 5bbd90550da8f7bdac769b5825597e67183c9411
config: alpha-allyesconfig (attached as .config)
compiler: alpha-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=alpha 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

   In file included from include/linux/kernel.h:11,
                    from drivers/staging/hf_manager/core/hf_manager.c:9:
   drivers/staging/hf_manager/core/hf_manager.c: In function 'hf_manager_io_schedule':
>> include/linux/compiler.h:301:1: error: expected expression before 'do'
     301 | do {         \
         | ^~
   arch/alpha/include/asm/atomic.h:34:27: note: in expansion of macro 'WRITE_ONCE'
      34 | #define atomic64_set(v,i) WRITE_ONCE((v)->counter, (i))
         |                           ^~~~~~~~~~
   drivers/staging/hf_manager/core/hf_manager.h:145:40: note: in expansion of macro 'atomic64_set'
     145 | #define set_interrupt_timestamp(m, t) (atomic64_set(&m->timestamp, t))
         |                                        ^~~~~~~~~~~~
   drivers/staging/hf_manager/core/hf_manager.c:171:2: note: in expansion of macro 'set_interrupt_timestamp'
     171 |  set_interrupt_timestamp(manager, timestamp);
         |  ^~~~~~~~~~~~~~~~~~~~~~~

vim +/do +301 include/linux/compiler.h

a5460b5e5fb826 Will Deacon 2019-12-16  299  
9e343b467c7037 Will Deacon 2019-12-13  300  #define WRITE_ONCE(x, val)						\
9e343b467c7037 Will Deacon 2019-12-13 @301  do {									\
9e343b467c7037 Will Deacon 2019-12-13  302  	compiletime_assert_rwonce_type(x);				\
44b97dccb2291a Marco Elver 2020-05-21  303  	__WRITE_ONCE(x, val);						\
9e343b467c7037 Will Deacon 2019-12-13  304  } while (0)
9e343b467c7037 Will Deacon 2019-12-13  305  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (65090 bytes)