lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 5 Aug 2020 20:29:29 +0800 From: 何鑫 <hexin.op@...edance.com> To: airlied@...ux.ie, kraxel@...hat.com, Daniel Vetter <daniel@...ll.ch> Cc: dri-devel@...ts.freedesktop.org, virtualization@...ts.linux-foundation.org, linux-kernel@...r.kernel.org, Qi Liu <liuqi.16@...edance.com> Subject: Re: [PATCH] drm/virtio: fix memory leak in virtio_gpu_cleanup_object() Xin He <hexin.op@...edance.com> 于2020年7月22日周三 下午1:19写道: > > Before setting shmem->pages to NULL, kfree() should > be called. > > Signed-off-by: Xin He <hexin.op@...edance.com> > Reviewed-by: Qi Liu <liuqi.16@...edance.com> > --- > drivers/gpu/drm/virtio/virtgpu_object.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/virtio/virtgpu_object.c b/drivers/gpu/drm/virtio/virtgpu_object.c > index 6ccbd01cd888..703b5cd51751 100644 > --- a/drivers/gpu/drm/virtio/virtgpu_object.c > +++ b/drivers/gpu/drm/virtio/virtgpu_object.c > @@ -79,6 +79,7 @@ void virtio_gpu_cleanup_object(struct virtio_gpu_object *bo) > } > > sg_free_table(shmem->pages); > + kfree(shmem->pages); > shmem->pages = NULL; > drm_gem_shmem_unpin(&bo->base.base); > } > -- > 2.21.1 (Apple Git-122.3) > Ping guys. Any comments or suggestions? -- Xin He
Powered by blists - more mailing lists