linux-kernel - Re: [PATCH] drm/virtio: fix memory leak in virtio_gpu_cleanup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200807124310.cmhbj6bj76twdtaw@sirius.home.kraxel.org>
Date:   Fri, 7 Aug 2020 14:43:10 +0200
From:   Gerd Hoffmann <kraxel@...hat.com>
To:     Xin He <hexin.op@...edance.com>
Cc:     airlied@...ux.ie, daniel@...ll.ch, dri-devel@...ts.freedesktop.org,
        virtualization@...ts.linux-foundation.org,
        linux-kernel@...r.kernel.org, Qi Liu <liuqi.16@...edance.com>
Subject: Re: [PATCH] drm/virtio: fix memory leak in
 virtio_gpu_cleanup_object()

On Wed, Jul 22, 2020 at 01:18:51PM +0800, Xin He wrote:
> Before setting shmem->pages to NULL, kfree() should
> be called.

>  			sg_free_table(shmem->pages);
> +			kfree(shmem->pages);
>  			shmem->pages = NULL;

Pushed to drm-misc-fixes.

thanks,
  Gerd