linux-kernel - Re: [Patch v2 2/4] dmaengine: tegra: Add Tegra GPC DMA driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <93b20bf7-1cb8-c8cf-06ef-1c15b7ce7ff2@gmail.com>
Date:   Thu, 6 Aug 2020 17:49:59 +0300
From:   Dmitry Osipenko <digetx@...il.com>
To:     Rajesh Gumasta <rgumasta@...dia.com>, ldewangan@...dia.com,
        jonathanh@...dia.com, vkoul@...nel.org, dan.j.williams@...el.com,
        thierry.reding@...il.com, p.zabel@...gutronix.de,
        dmaengine@...r.kernel.org, linux-tegra@...r.kernel.org,
        linux-kernel@...r.kernel.org
Cc:     kyarlagadda@...dia.com, Pavan Kunapuli <pkunapuli@...dia.com>
Subject: Re: [Patch v2 2/4] dmaengine: tegra: Add Tegra GPC DMA driver

06.08.2020 10:30, Rajesh Gumasta пишет:
> +static struct dma_async_tx_descriptor *tegra_dma_prep_dma_memset(
> +	struct dma_chan *dc, dma_addr_t dest, int value, size_t len,
> +	unsigned long flags)
> +{

This looks and reads okay, although the following style of code's
formatting is a bit more common for the kernel:

static struct dma_async_tx_descriptor *
tegra_dma_prep_dma_memset(struct dma_chan *dc, dma_addr_t dest,
			  int value, size_t len, unsigned long flags)

You could make this small improvement in a v3. Same for all similar
cases in the code.