linux-kernel - Re: [RFC PATCH 1/3] selftests: Add VRF icmp error route lookup test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <42cb74c8-9391-cf4c-9e57-7a1d464f8706@gmail.com>
Date:   Thu, 6 Aug 2020 11:00:24 -0600
From:   David Ahern <dsahern@...il.com>
To:     Mathieu Desnoyers <mathieu.desnoyers@...icios.com>,
        David Ahern <dsa@...ulusnetworks.com>
Cc:     linux-kernel@...r.kernel.org,
        Michael Jeanson <mjeanson@...icios.com>,
        "David S . Miller" <davem@...emloft.net>, netdev@...r.kernel.org
Subject: Re: [RFC PATCH 1/3] selftests: Add VRF icmp error route lookup test

On 7/29/20 3:12 PM, Mathieu Desnoyers wrote:
> From: Michael Jeanson <mjeanson@...icios.com>
> 
> The objective is to check that the incoming vrf routing table is selected
> to send an ICMP error back to the source when the ttl of a packet reaches 1
> while it is forwarded between different vrfs.
> 
> The first test sends a ping with a ttl of 1 from h1 to h2 and parses the
> output of the command to check that a ttl expired error is received.
> 
> [This may be flaky, I'm open to suggestions of a more robust approch.]
> 
> The second test runs traceroute from h1 to h2 and parses the output to check
> for a hop on r1.
> 
> Signed-off-by: Michael Jeanson <mjeanson@...icios.com>
> Cc: David Ahern <dsa@...ulusnetworks.com>

Update the address to dsahern@...nel.org


> Cc: David S. Miller <davem@...emloft.net>
> Cc: netdev@...r.kernel.org
> ---
>  tools/testing/selftests/net/Makefile          |   1 +
>  .../selftests/net/vrf_icmp_error_route.sh     | 461 ++++++++++++++++++
>  2 files changed, 462 insertions(+)
>  create mode 100755 tools/testing/selftests/net/vrf_icmp_error_route.sh
> 

Test seems fine to me. you copied icmp_redirect.sh which is fine but
please clean up comments and functions not needed for this test.