linux-kernel - Re: [PATCH v3] drm/virtio: fix missing dma_fence_put() in virtio_gpu_execbuffer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200807055241.GA3025028@kroah.com>
Date:   Fri, 7 Aug 2020 07:52:41 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     何鑫 <hexin.op@...edance.com>
Cc:     Daniel Vetter <daniel@...ll.ch>, airlied@...ux.ie,
        kraxel@...hat.com, Sumit Semwal <sumit.semwal@...aro.org>,
        linux-kernel@...r.kernel.org, dri-devel@...ts.freedesktop.org,
        virtualization@...ts.linux-foundation.org,
        linux-media@...r.kernel.org, Qi Liu <liuqi.16@...edance.com>,
        Muchun Song <songmuchun@...edance.com>
Subject: Re: [PATCH v3] drm/virtio: fix missing dma_fence_put() in
 virtio_gpu_execbuffer_ioctl()

On Fri, Aug 07, 2020 at 11:00:11AM +0800, 何鑫 wrote:
> Xin He <hexin.op@...edance.com> 于2020年7月21日周二 下午6:17写道：
> >
> > From: Qi Liu <liuqi.16@...edance.com>
> >
> > We should put the reference count of the fence after calling
> > virtio_gpu_cmd_submit(). So add the missing dma_fence_put().
> >
> > Fixes: 2cd7b6f08bc4 ("drm/virtio: add in/out fence support for explicit synchronization")
> > Co-developed-by: Xin He <hexin.op@...edance.com>
> > Signed-off-by: Xin He <hexin.op@...edance.com>
> > Signed-off-by: Qi Liu <liuqi.16@...edance.com>
> > Reviewed-by: Muchun Song <songmuchun@...edance.com>
> > ---
> >
> > changelog in v3:
> > 1) Change the subject from "drm/virtio: fixed memory leak in virtio_gpu_execbuffer_ioctl()" to
> >    "drm/virtio: fix missing dma_fence_put() in virtio_gpu_execbuffer_ioctl()"
> > 2) Rework the commit log
> >
> > changelog in v2:
> > 1) Add a change description
> >
> >  drivers/gpu/drm/virtio/virtgpu_ioctl.c | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/gpu/drm/virtio/virtgpu_ioctl.c b/drivers/gpu/drm/virtio/virtgpu_ioctl.c
> > index 5df722072ba0..19c5bc01eb79 100644
> > --- a/drivers/gpu/drm/virtio/virtgpu_ioctl.c
> > +++ b/drivers/gpu/drm/virtio/virtgpu_ioctl.c
> > @@ -179,6 +179,7 @@ static int virtio_gpu_execbuffer_ioctl(struct drm_device *dev, void *data,
> >
> >         virtio_gpu_cmd_submit(vgdev, buf, exbuf->size,
> >                               vfpriv->ctx_id, buflist, out_fence);
> > +       dma_fence_put(&out_fence->f);
> >         virtio_gpu_notify(vgdev);
> >         return 0;
> >
> > --
> > 2.21.1 (Apple Git-122.3)
> >
> 
> cc Greg

Why?

$ ./scripts/get_maintainer.pl --file drivers/gpu/drm/virtio/virtgpu_ioctl.c
David Airlie <airlied@...ux.ie> (maintainer:VIRTIO GPU DRIVER)
Gerd Hoffmann <kraxel@...hat.com> (maintainer:VIRTIO GPU DRIVER)
Daniel Vetter <daniel@...ll.ch> (maintainer:DRM DRIVERS)
Sumit Semwal <sumit.semwal@...aro.org> (maintainer:DMA BUFFER SHARING FRAMEWORK)
"Christian König" <christian.koenig@....com> (maintainer:DMA BUFFER SHARING FRAMEWORK)
dri-devel@...ts.freedesktop.org (open list:VIRTIO GPU DRIVER)
virtualization@...ts.linux-foundation.org (open list:VIRTIO GPU DRIVER)
linux-kernel@...r.kernel.org (open list)
linux-media@...r.kernel.org (open list:DMA BUFFER SHARING FRAMEWORK)
linaro-mm-sig@...ts.linaro.org (moderated list:DMA BUFFER SHARING FRAMEWORK)