linux-kernel - Re: [PATCH v3] drm/virtio: fix missing dma_fence_put() in virtio_gpu_execbuffer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200807115704.4epnok7vxwdmemns@sirius.home.kraxel.org>
Date:   Fri, 7 Aug 2020 13:57:04 +0200
From:   Gerd Hoffmann <kraxel@...hat.com>
To:     Xin He <hexin.op@...edance.com>
Cc:     daniel@...ll.ch, airlied@...ux.ie, sumit.semwal@...aro.org,
        linux-kernel@...r.kernel.org, dri-devel@...ts.freedesktop.org,
        virtualization@...ts.linux-foundation.org,
        linux-media@...r.kernel.org, linaro-mm-sig@...ts.linaro.org,
        Qi Liu <liuqi.16@...edance.com>,
        Muchun Song <songmuchun@...edance.com>
Subject: Re: [PATCH v3] drm/virtio: fix missing dma_fence_put() in
 virtio_gpu_execbuffer_ioctl()

On Tue, Jul 21, 2020 at 06:16:47PM +0800, Xin He wrote:
> From: Qi Liu <liuqi.16@...edance.com>
> 
> We should put the reference count of the fence after calling
> virtio_gpu_cmd_submit(). So add the missing dma_fence_put().

>  	virtio_gpu_cmd_submit(vgdev, buf, exbuf->size,
>  			      vfpriv->ctx_id, buflist, out_fence);
> +	dma_fence_put(&out_fence->f);
>  	virtio_gpu_notify(vgdev);

Pushed to drm-misc-fixes.

thanks,
  Gerd