linux-kernel - Re: [PATCH] ASoC: amd: Replacing component->name with codec

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200807115414.GI5435@sirena.org.uk>
Date:   Fri, 7 Aug 2020 12:54:14 +0100
From:   Mark Brown <broonie@...nel.org>
To:     "RAVULAPATI, VISHNU VARDHAN RAO" 
        <Vishnuvardhanrao.Ravulapati@....com>
Cc:     Liam Girdwood <lgirdwood@...il.com>,
        Jaroslav Kysela <perex@...ex.cz>,
        Takashi Iwai <tiwai@...e.com>,
        Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>,
        YueHaibing <yuehaibing@...wei.com>,
        "moderated list:SOUND - SOC LAYER / DYNAMIC AUDIO POWER MANAGEM..." 
        <alsa-devel@...a-project.org>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ASoC: amd: Replacing component->name with codec_dai->name

On Fri, Aug 07, 2020 at 08:36:25AM +0000, RAVULAPATI, VISHNU VARDHAN RAO wrote:
> On Thu, Aug 06, 2020 at 03:44:12PM +0530, Ravulapati Vishnu vardhan rao wrote:

> > Replacing string compare with codec_dai->name instead of comparing 
> > with codec_dai->component->name in hw_params.

> >Why?

> Here the component name for codec RT1015 is "i2c-10EC1015:00" and will never be "rt1015-aif1"
> As it is codec-dai->name so the strcmp always compares and fails to set the sysclk,pll,bratio of expected codec-dai

This should be in the changelog so people can understand why the change
was made.

Please fix your mail client to word wrap within paragraphs at something
substantially less than 80 columns.  Doing this makes your messages much
easier to read and reply to.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)