linux-kernel - Re: [PATCH v9 3/5] drm/msm/dp: add support for DP PLL driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 7 Aug 2020 08:51:48 -0700
From:   Rob Clark <robdclark@...il.com>
To:     Randy Dunlap <rdunlap@...radead.org>
Cc:     Tanmay Shah <tanmay@...eaurora.org>,
        Stephen Boyd <swboyd@...omium.org>,
        linux-arm-msm <linux-arm-msm@...r.kernel.org>,
        dri-devel <dri-devel@...ts.freedesktop.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        freedreno <freedreno@...ts.freedesktop.org>,
        Sean Paul <seanpaul@...omium.org>,
        Daniel Vetter <daniel@...ll.ch>,
        David Airlie <airlied@...ux.ie>, aravindh@...eaurora.org,
        Abhinav Kumar <abhinavk@...eaurora.org>, khsieh@...eaurora.org,
        Chandan Uddaraju <chandanu@...eaurora.org>,
        Vara Reddy <varar@...eaurora.org>
Subject: Re: [PATCH v9 3/5] drm/msm/dp: add support for DP PLL driver

On Fri, Aug 7, 2020 at 8:27 AM Randy Dunlap <rdunlap@...radead.org> wrote:
>
> On 8/7/20 12:17 AM, Tanmay Shah wrote:
> > diff --git a/drivers/gpu/drm/msm/Kconfig b/drivers/gpu/drm/msm/Kconfig
> > index ea3c4d094d09..cc1392b29022 100644
> > --- a/drivers/gpu/drm/msm/Kconfig
> > +++ b/drivers/gpu/drm/msm/Kconfig
> > @@ -60,6 +60,7 @@ config DRM_MSM_HDMI_HDCP
> >  config DRM_MSM_DP
> >       bool "Enable DP support in MSM DRM driver"
> >       depends on DRM_MSM
> > +     default y
> >       help
> >         Compile in support for DP driver in msm drm driver. DP external
> >         display support is enabled through this config option. It can
>
> Hi,
>
> You need a very strong justification to make an optional part of a driver
> to be "default y".

My opinion is that if the driver is built, everything should be built.
This is what makes sense for distro's.  It is only the embedded case
where you want to trim down unneeded features where you might want to
disable some parts.  So 'default y' makes sense to me.

BR,
-R

> so why?
>
> thanks.
> --
> ~Randy
>