linux-kernel - Re: [PATCH v9 3/5] drm/msm/dp: add support for DP PLL driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <29b8d7f281aa69df491bedd1e6b6fac6@codeaurora.org>
Date:   Fri, 07 Aug 2020 08:54:54 -0700
From:   tanmay@...eaurora.org
To:     Randy Dunlap <rdunlap@...radead.org>
Cc:     swboyd@...omium.org, linux-arm-msm@...r.kernel.org,
        dri-devel@...ts.freedesktop.org, robdclark@...il.com,
        linux-kernel@...r.kernel.org, freedreno@...ts.freedesktop.org,
        seanpaul@...omium.org, daniel@...ll.ch, airlied@...ux.ie,
        aravindh@...eaurora.org, abhinavk@...eaurora.org,
        khsieh@...eaurora.org, Chandan Uddaraju <chandanu@...eaurora.org>,
        Vara Reddy <varar@...eaurora.org>
Subject: Re: [PATCH v9 3/5] drm/msm/dp: add support for DP PLL driver

On 2020-08-07 08:27, Randy Dunlap wrote:
> On 8/7/20 12:17 AM, Tanmay Shah wrote:
>> diff --git a/drivers/gpu/drm/msm/Kconfig b/drivers/gpu/drm/msm/Kconfig
>> index ea3c4d094d09..cc1392b29022 100644
>> --- a/drivers/gpu/drm/msm/Kconfig
>> +++ b/drivers/gpu/drm/msm/Kconfig
>> @@ -60,6 +60,7 @@ config DRM_MSM_HDMI_HDCP
>>  config DRM_MSM_DP
>>  	bool "Enable DP support in MSM DRM driver"
>>  	depends on DRM_MSM
>> +	default y
>>  	help
>>  	  Compile in support for DP driver in msm drm driver. DP external
>>  	  display support is enabled through this config option. It can
> 
> Hi,
> 
> You need a very strong justification to make an optional part of a 
> driver
> to be "default y".
> 
> so why?
> 
Thanks Randy for reviews.
"default y" doesn't belong there. Thanks for pointing that.
It will be fixed in next patch.

> thanks.