linux-kernel - Re: [PATCH] MIPS: CI20: Update defconfig for EFUSE.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <d8b28bac-8995-23db-816e-31ba1f8d02f3@wanyeetech.com>
Date:   Fri, 7 Aug 2020 23:55:18 +0800
From:   Zhou Yanjie <zhouyanjie@...yeetech.com>
To:     Paul Cercueil <paul@...pouillou.net>
Cc:     tsbogend@...ha.franken.de, linux-kernel@...r.kernel.org,
        linux-mips@...r.kernel.org, keescook@...omium.org,
        hns@...delico.com, ebiederm@...ssion.com,
        dongsheng.qiu@...enic.com, aric.pzqi@...enic.com,
        rick.tyliu@...enic.com, yanfei.li@...enic.com,
        sernia.zhou@...mail.com, zhenwenjin@...il.com
Subject: Re: [PATCH] MIPS: CI20: Update defconfig for EFUSE.

Hi Paul,

在 2020/7/28 下午11:40, Paul Cercueil 写道:
> Hi Zhou,
>
> Le sam. 25 juil. 2020 à 16:02, Zhou Yanjie <zhouyanjie@...yeetech.com> 
> a écrit :
>> Hi Paul,
>>
>> 在 2020/7/23 下午4:47, Paul Cercueil 写道:
>>> Hi Zhou,
>>>
>>> Le jeu. 23 juil. 2020 à 15:19, 周琰杰 (Zhou Yanjie) 
>>> <zhouyanjie@...yeetech.com> a écrit :
>>>> The commit 19c968222934 ("MIPS: DTS: CI20: make DM9000 Ethernet
>>>> controller use NVMEM to find the default MAC address") add EFUSE
>>>> node for DM9000 in CI20, however, the EFUSE driver is not selected,
>>>> which will cause the DM9000 to fail to read the MAC address from
>>>> EFUSE, causing the following issue:
>>>>
>>>> [FAILED] Failed to start Raise network interfaces.
>>>>
>>>> Fix this problem by select CONFIG_JZ4780_EFUSE by default in the
>>>> ci20_defconfig.
>>>
>>> Does it actually fix it on a clean 5.8-rc kernel?
>>>
>>> From what I know, the efuse driver cannot probe, because the nemc 
>>> driver requests the complete memory resource, so the efuse driver's 
>>> devm_platform_ioremap_resource() fails.
>>>
>>> I did send a patch to fix this 
>>> (https://lore.kernel.org/lkml/551a8560261543c1decb1d4d1671ec4b7fa52fdb.1582905653.git.hns@goldelico.com/),
>>> but it's hard to have somebody merge it, because nobody maintains 
>>> drivers/memory/.
>>>
>> You are right, I cleaned up the changes made to support X1000's EFUSE 
>> and rebase to clean 5.8-RC6, it still does not work properly, I think 
>> we should drop this fix patch.
>
> The patch I mentioned was merged, so starting from 5.9-rc1 the efuse 
> driver should work. Please resend this patch after 5.9-rc1 then.
>

Sure, I will resent when 5.9-rc1 is released.

Thanks and best regards!

> Thanks,
> -Paul
>
>>
>>>> Fixes: 19c968222934 ("MIPS: DTS: CI20: make DM9000 Ethernet
>>>> controller use NVMEM to find the default MAC address").
>>>
>>> That shouldn't be a fix IMHO - the devicetree was updated in one 
>>> commit, the config should be updated in another. The "bug" here is 
>>> that it wasn't done right away.
>>>
>> Okay.
>>>> Signed-off-by: 周琰杰 (Zhou Yanjie) <zhouyanjie@...yeetech.com>
>>>
>>> Btw - when you add a Fixes: tag to fix a commit that is not for the 
>>> kernel currently in RC phase, you need to Cc linux-stable as well.
>>>
>> Sure, I will pay attention next time.
>>
>> Thanks and best regards!
>>
>>
>>> Cheers,
>>> -Paul
>>>
>>>> ---
>>>>  arch/mips/configs/ci20_defconfig | 1 +
>>>>  1 file changed, 1 insertion(+)
>>>>
>>>> diff --git a/arch/mips/configs/ci20_defconfig 
>>>> b/arch/mips/configs/ci20_defconfig
>>>> index f433fad16073..ba26ba4de09a 100644
>>>> --- a/arch/mips/configs/ci20_defconfig
>>>> +++ b/arch/mips/configs/ci20_defconfig
>>>> @@ -140,6 +140,7 @@ CONFIG_INGENIC_OST=y
>>>>  CONFIG_MEMORY=y
>>>>  CONFIG_PWM=y
>>>>  CONFIG_PWM_JZ4740=m
>>>> +CONFIG_JZ4780_EFUSE=y
>>>>  CONFIG_EXT4_FS=y
>>>>  # CONFIG_DNOTIFY is not set
>>>>  CONFIG_AUTOFS_FS=y
>>>> -- 
>>>> 2.11.0
>>>>
>>>
>