lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 9 Aug 2020 11:46:33 -0500 From: Steve French <smfrench@...il.com> To: linmiaohe <linmiaohe@...wei.com> Cc: Steve French <sfrench@...ba.org>, CIFS <linux-cifs@...r.kernel.org>, samba-technical <samba-technical@...ts.samba.org>, LKML <linux-kernel@...r.kernel.org> Subject: Re: [PATCH] cifs: Convert to use the fallthrough macro Is this conversion from "/* Fallthrough */" to the preferred (?) "fallthrough;" documented anywhere? All I see is a few fs changesets like: commit c730ae0c6bb3125ccb776fb2ab6abbdff500c02c Author: Marcos Paulo de Souza <mpdesouza@...e.com> Date: Tue Jun 16 15:54:29 2020 -0300 btrfs: convert comments to fallthrough annotations Convert fall through comments to the pseudo-keyword which is now the preferred way. And the vast majority of places (33 vs. 4) use "/* Fallthrough */ in the fs directory On Sat, Aug 8, 2020 at 3:34 AM linmiaohe <linmiaohe@...wei.com> wrote: > > From: Miaohe Lin <linmiaohe@...wei.com> > > Convert the uses of fallthrough comments to fallthrough macro. > > Signed-off-by: Hongxiang Lou <louhongxiang@...wei.com> > Signed-off-by: Miaohe Lin <linmiaohe@...wei.com> > --- > fs/cifs/smb2pdu.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/fs/cifs/smb2pdu.c b/fs/cifs/smb2pdu.c > index 24c2ac360591..667d70aa335f 100644 > --- a/fs/cifs/smb2pdu.c > +++ b/fs/cifs/smb2pdu.c > @@ -3913,7 +3913,7 @@ smb2_readv_callback(struct mid_q_entry *mid) > case MID_RESPONSE_MALFORMED: > credits.value = le16_to_cpu(shdr->CreditRequest); > credits.instance = server->reconnect_instance; > - /* fall through */ > + fallthrough; > default: > rdata->result = -EIO; > } > @@ -4146,7 +4146,7 @@ smb2_writev_callback(struct mid_q_entry *mid) > case MID_RESPONSE_MALFORMED: > credits.value = le16_to_cpu(rsp->sync_hdr.CreditRequest); > credits.instance = server->reconnect_instance; > - /* fall through */ > + fallthrough; > default: > wdata->result = -EIO; > break; > -- > 2.19.1 > -- Thanks, Steve
Powered by blists - more mailing lists