linux-kernel - Re: [PATCH] ALSA: echoaudio: Fix memory leak in snd_echo

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <s5h7du76lew.wl-tiwai@suse.de>
Date:   Mon, 10 Aug 2020 08:54:15 +0200
From:   Takashi Iwai <tiwai@...e.de>
To:     Dinghao Liu <dinghao.liu@....edu.cn>
Cc:     kjlu@....edu, Jaroslav Kysela <perex@...ex.cz>,
        Takashi Iwai <tiwai@...e.com>, Mark Hills <mark@...x.org>,
        Dan Carpenter <dan.carpenter@...cle.com>,
        Arnd Bergmann <arnd@...db.de>,
        Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>,
        Takashi Sakamoto <o-takashi@...amocchi.jp>,
        Giuliano Pochini <pochini@...ny.it>,
        alsa-devel@...a-project.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ALSA: echoaudio: Fix memory leak in snd_echo_resume()

On Mon, 10 Aug 2020 08:14:58 +0200,
Dinghao Liu wrote:
> 
> When restore_dsp_rettings() fails, chip should be freed
> just like when init_hw() and request_irq() fails.
> 
> Fixes: 47b5d028fdce8 ("ALSA: Echoaudio - Add suspend support #2")
> Signed-off-by: Dinghao Liu <dinghao.liu@....edu.cn>

Actually it's rather wrong to call snd_echo_free() in the resume error
path.  This may lead to an Oops at the next time the system goes to
resume.  That said, we should drop snd_echo_free() calls in other
error paths in snd_echo_resume() instead.


thanks,

Takashi


> ---
>  sound/pci/echoaudio/echoaudio.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/sound/pci/echoaudio/echoaudio.c b/sound/pci/echoaudio/echoaudio.c
> index 6aeb99aa2414..2aa183fe5dc1 100644
> --- a/sound/pci/echoaudio/echoaudio.c
> +++ b/sound/pci/echoaudio/echoaudio.c
> @@ -2226,6 +2226,7 @@ static int snd_echo_resume(struct device *dev)
>  	chip->pipe_alloc_mask = pipe_alloc_mask;
>  	if (err < 0) {
>  		kfree(commpage_bak);
> +		snd_echo_free(chip);
>  		return err;
>  	}
>  
> -- 
> 2.17.1
>