linux-kernel - Re: Re: [PATCH] ALSA: echoaudio: Fix memory leak in snd_echo

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <cdb962d.569f9.173e68fb9e9.Coremail.dinghao.liu@zju.edu.cn>
Date:   Thu, 13 Aug 2020 14:44:05 +0800 (GMT+08:00)
From:   dinghao.liu@....edu.cn
To:     "Takashi Iwai" <tiwai@...e.de>
Cc:     kjlu@....edu, "Jaroslav Kysela" <perex@...ex.cz>,
        "Takashi Iwai" <tiwai@...e.com>, "Mark Hills" <mark@...x.org>,
        "Dan Carpenter" <dan.carpenter@...cle.com>,
        "Arnd Bergmann" <arnd@...db.de>,
        "Pierre-Louis Bossart" <pierre-louis.bossart@...ux.intel.com>,
        "Takashi Sakamoto" <o-takashi@...amocchi.jp>,
        "Giuliano Pochini" <pochini@...ny.it>, alsa-devel@...a-project.org,
        linux-kernel@...r.kernel.org
Subject: Re: Re: [PATCH] ALSA: echoaudio: Fix memory leak in
 snd_echo_resume()


> On Mon, 10 Aug 2020 08:14:58 +0200,
> Dinghao Liu wrote:
> > 
> > When restore_dsp_rettings() fails, chip should be freed
> > just like when init_hw() and request_irq() fails.
> > 
> > Fixes: 47b5d028fdce8 ("ALSA: Echoaudio - Add suspend support #2")
> > Signed-off-by: Dinghao Liu <dinghao.liu@....edu.cn>
> 
> Actually it's rather wrong to call snd_echo_free() in the resume error
> path.  This may lead to an Oops at the next time the system goes to
> resume.  That said, we should drop snd_echo_free() calls in other
> error paths in snd_echo_resume() instead.
> 

Thank you for your advice! I will send a new patch to fix this soon.

Regards,
Dinghao