linux-kernel - Re: Re: [PATCH] ALSA: pci/asihpi: Fix memory leak in snd_card_asihpi_capture

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <77ed04d7.569ba.173e68b5d88.Coremail.dinghao.liu@zju.edu.cn>
Date:   Thu, 13 Aug 2020 14:39:19 +0800 (GMT+08:00)
From:   dinghao.liu@....edu.cn
To:     "Takashi Iwai" <tiwai@...e.de>
Cc:     kjlu@....edu, "Jaroslav Kysela" <perex@...ex.cz>,
        "Takashi Iwai" <tiwai@...e.com>,
        "Pierre-Louis Bossart" <pierre-louis.bossart@...ux.intel.com>,
        "Eliot Blennerhassett" <eblennerhassett@...ioscience.com>,
        alsa-devel@...a-project.org, linux-kernel@...r.kernel.org
Subject: Re: Re: [PATCH] ALSA: pci/asihpi: Fix memory leak in
 snd_card_asihpi_capture_open()

> On Mon, 10 Aug 2020 08:39:55 +0200,
> Dinghao Liu wrote:
> > 
> > When snd_pcm_hw_constraint_pow2() fails, dpcm should be freed
> > just like when hpi_instream_open()  fails.
> 
> It will be cleaned up via runtime->private_free call in the caller
> side (snd_pcm_open -> snd_pcm_release_substream ->
> snd_pcm_detach_substream), hence this would result in double-free.
> 

It's clear to me, thanks!

Regards,
Dinghao