linux-kernel - Re: [PATCH V6 02/16] perf/x86/intel: Support PERF_SAMPLE_DATA_PAGE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2dc7c2c2-4f5f-09a9-8c1b-baf294da08b1@linux.intel.com>
Date:   Mon, 10 Aug 2020 18:36:38 -0400
From:   "Liang, Kan" <kan.liang@...ux.intel.com>
To:     Peter Zijlstra <peterz@...radead.org>
Cc:     acme@...nel.org, mingo@...hat.com, linux-kernel@...r.kernel.org,
        mark.rutland@....com, alexander.shishkin@...ux.intel.com,
        jolsa@...hat.com, eranian@...gle.com, ak@...ux.intel.com,
        dave.hansen@...el.com, kirill.shutemov@...ux.intel.com
Subject: Re: [PATCH V6 02/16] perf/x86/intel: Support
 PERF_SAMPLE_DATA_PAGE_SIZE



On 8/10/2020 5:40 PM, Peter Zijlstra wrote:
> On Mon, Aug 10, 2020 at 02:24:22PM -0700, Kan Liang wrote:
>> The new sample type, PERF_SAMPLE_DATA_PAGE_SIZE, requires the virtual
>> address. Update the data->addr if the sample type is set.
>>
>> The large PEBS is disabled with the sample type, because perf doesn't
>> support munmap tracking yet. The PEBS buffer for large PEBS cannot be
>> flushed for each munmap. Wrong page size may be calculated. The large
>> PEBS can be enabled later separately when munmap tracking is supported.
> 
> 
> You also get to fix up Power.
> 
> arch/powerpc/perf/core-book3s.c:                    (PERF_SAMPLE_ADDR | PERF_SAMPLE_PHYS_ADDR))

Sure. I will add one patch for Power.

Thanks,
Kan