lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 10 Aug 2020 13:25:25 +0100 From: Guillaume Tucker <guillaume.tucker@...labora.com> To: Russell King - ARM Linux admin <linux@...linux.org.uk>, Krzysztof Kozlowski <krzk@...nel.org> Cc: Kukjin Kim <kgene@...nel.org>, Rob Herring <robh+dt@...nel.org>, kernel@...labora.com, devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, linux-samsung-soc@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH 1/3] ARM: exynos: clear L220_AUX_CTRL_NS_LOCKDOWN in default l2c_aux_val On 03/08/2020 15:22, Russell King - ARM Linux admin wrote: > On Mon, Aug 03, 2020 at 03:34:39PM +0200, Krzysztof Kozlowski wrote: >> On Wed, Jul 29, 2020 at 02:47:31PM +0100, Guillaume Tucker wrote: >>> The L220_AUX_CTRL_NS_LOCKDOWN flag is set during the L2C enable >>> sequence. There is no need to set it in the default register value, >>> this was done before support for it was implemented in the code. It >>> is not set in the hardware initial value either. >>> >>> Clean this up by removing this flag from the default l2c_aux_val, and >>> add it to the l2c_aux_mask to print an alert message if it was already >>> set before the kernel initialisation. >>> >>> Signed-off-by: Guillaume Tucker <guillaume.tucker@...labora.com> >>> --- >>> arch/arm/mach-exynos/exynos.c | 4 ++-- >>> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> Makes sense. I'll take it after the merge window. > > Yes, because platforms actually have no control over this bit through > these values. > > Please fix the description to use the right define, it's > L310_AUX_CTRL_NS_LOCKDOWN not L220_AUX_CTRL_NS_LOCKDOWN. Thanks, fixed in v2. Guilaume
Powered by blists - more mailing lists