linux-kernel - Re: [PATCH v2 1/2] i2c: eg20t: Drop PCI wakeup calls from .suspend/.resume

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 10 Aug 2020 16:01:35 +0200
From:   Wolfram Sang <wsa@...nel.org>
To:     Vaibhav Gupta <vaibhavgupta40@...il.com>
Cc:     Bjorn Helgaas <helgaas@...nel.org>,
        Bjorn Helgaas <bhelgaas@...gle.com>,
        Vaibhav Gupta <vaibhav.varodek@...il.com>,
        Tomoya MORINAGA <tomoya-linux@....okisemi.com>,
        Tomoya MORINAGA <tomoya.rohm@...il.com>,
        Linus Walleij <linus.walleij@...aro.org>,
        Ben Dooks <ben.dooks@...ethink.co.uk>,
        linux-i2c@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-kernel-mentees@...ts.linuxfoundation.org,
        Shuah Khan <skhan@...uxfoundation.org>
Subject: Re: [PATCH v2 1/2] i2c: eg20t: Drop PCI wakeup calls from
 .suspend/.resume

On Thu, Aug 06, 2020 at 01:06:15AM +0530, Vaibhav Gupta wrote:
> The driver calls pci_enable_wake(...., false) in pch_i2c_suspend() as well
> as pch_i2c_resume(). Either it should enable-wake the device in .suspend()
> or should not invoke pci_enable_wake() at all.
> 
> Concluding that this driver doesn't support enable-wake and PCI core calls
> pci_enable_wake(pci_dev, PCI_D0, false) during resume, drop it from
> .suspend() and .resume().
> 
> Reported-by: Bjorn Helgaas <helgaas@...nel.org>
> Signed-off-by: Vaibhav Gupta <vaibhavgupta40@...il.com>

Applied to for-next, thanks!


Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)