linux-kernel - RE: [RFT PATCH v5] serial: samsung: Removes the IRQ not found warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <003c01d66f33$1065a380$3130ea80$@samsung.com>
Date:   Mon, 10 Aug 2020 21:56:52 +0530
From:   "Alim Akhtar" <alim.akhtar@...sung.com>
To:     "'Tamseel Shams'" <m.shams@...sung.com>, <kgene@...nel.org>,
        <krzk@...nel.org>, <gregkh@...uxfoundation.org>, <jslaby@...e.com>
Cc:     <linux-arm-kernel@...ts.infradead.org>,
        <linux-samsung-soc@...r.kernel.org>,
        <linux-serial@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: RE: [RFT PATCH v5] serial: samsung: Removes the IRQ not found
 warning

Hi Tamseel,

> -----Original Message-----
> From: Tamseel Shams <m.shams@...sung.com>
> Sent: 10 August 2020 08:30
> To: kgene@...nel.org; krzk@...nel.org; gregkh@...uxfoundation.org;
> jslaby@...e.com
> Cc: linux-arm-kernel@...ts.infradead.org; linux-samsung-soc@...r.kernel.org;
> linux-serial@...r.kernel.org; linux-kernel@...r.kernel.org;
> alim.akhtar@...sung.com; Tamseel Shams <m.shams@...sung.com>
> Subject: [RFT PATCH v5] serial: samsung: Removes the IRQ not found warning
> 
> In few older Samsung SoCs like s3c2410, s3c2412 and s3c2440, UART IP is having
> 2 interrupt lines.
> However, in other SoCs like s3c6400, s5pv210, exynos5433, and exynos4210
> UART is having only 1 interrupt line. Due to this, "platform_get_irq(platdev, 1)"
> call in the driver gives the following false-positive error:
> "IRQ index 1 not found" on newer SoC's.
> 
> This patch adds the condition to check for Tx interrupt only for the those SoC's
> which have 2 interrupt lines.
> 
> Signed-off-by: Tamseel Shams <m.shams@...sung.com>
> ---
Tested on exynos7 platform, don’t see " IRQ index 1 not found" with this patch applied
Fill free to added 
Tested-by: Alim Akhtar <alim.akhtar@...sung.com>
Reviewed-by: Alim Akhtar <alim.akhtar@...sung.com>

> Commit message is changed.
> 
> Added RFT, for older platform.
> 
> Addressed Krzysztof's review comments [1] [1] ->
> https://lkml.org/lkml/2020/7/21/150
> 
>  drivers/tty/serial/samsung_tty.c | 8 +++++---
>  1 file changed, 5 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/tty/serial/samsung_tty.c b/drivers/tty/serial/samsung_tty.c
> index 6ef614d8648c..b923683e6a25 100644
> --- a/drivers/tty/serial/samsung_tty.c
> +++ b/drivers/tty/serial/samsung_tty.c
> @@ -1911,9 +1911,11 @@ static int s3c24xx_serial_init_port(struct
> s3c24xx_uart_port *ourport,
>  		ourport->tx_irq = ret + 1;
>  	}
> 
> -	ret = platform_get_irq(platdev, 1);
> -	if (ret > 0)
> -		ourport->tx_irq = ret;
> +	if (!s3c24xx_serial_has_interrupt_mask(port)) {
> +		ret = platform_get_irq(platdev, 1);
> +		if (ret > 0)
> +			ourport->tx_irq = ret;
> +	}
>  	/*
>  	 * DMA is currently supported only on DT platforms, if DMA properties
>  	 * are specified.
> --
> 2.17.1