linux-kernel - Re: [RFT PATCH v5] serial: samsung: Removes the IRQ not found warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8a28be2a-e523-563c-b80a-19508b739b46@samsung.com>
Date:   Tue, 11 Aug 2020 11:39:54 +0200
From:   Marek Szyprowski <m.szyprowski@...sung.com>
To:     Tamseel Shams <m.shams@...sung.com>, kgene@...nel.org,
        krzk@...nel.org, gregkh@...uxfoundation.org, jslaby@...e.com
Cc:     linux-arm-kernel@...ts.infradead.org,
        linux-samsung-soc@...r.kernel.org, linux-serial@...r.kernel.org,
        linux-kernel@...r.kernel.org, alim.akhtar@...sung.com
Subject: Re: [RFT PATCH v5] serial: samsung: Removes the IRQ not found
 warning

Hi

On 10.08.2020 05:00, Tamseel Shams wrote:
> In few older Samsung SoCs like s3c2410, s3c2412
> and s3c2440, UART IP is having 2 interrupt lines.
> However, in other SoCs like s3c6400, s5pv210,
> exynos5433, and exynos4210 UART is having only 1
> interrupt line. Due to this, "platform_get_irq(platdev, 1)"
> call in the driver gives the following false-positive error:
> "IRQ index 1 not found" on newer SoC's.
>
> This patch adds the condition to check for Tx interrupt
> only for the those SoC's which have 2 interrupt lines.
>
> Signed-off-by: Tamseel Shams <m.shams@...sung.com>

Indeed, it removes the warning on various Exynos{3,4,5} based boards.

Tested-by: Marek Szyprowski <m.szyprowski@...sung.com>

> > ...

Best regards
-- 
Marek Szyprowski, PhD
Samsung R&D Institute Poland