linux-kernel - Re: [GIT PULL] sound updates for 5.9

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4f3ead7e-992e-edec-e7b4-31566fc5e583@linaro.org>
Date:   Mon, 10 Aug 2020 18:06:14 +0100
From:   Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
To:     John Stultz <john.stultz@...aro.org>, Takashi Iwai <tiwai@...e.de>,
        Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>
Cc:     Linus Torvalds <torvalds@...ux-foundation.org>,
        Mark Brown <broonie@...nel.org>,
        Liam Girdwood <lgirdwood@...il.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Amit Pundir <amit.pundir@...aro.org>,
        Vinod Koul <vkoul@...nel.org>
Subject: Re: [GIT PULL] sound updates for 5.9

Hi John,
Thanks for reporting this.

On 08/08/2020 01:23, John Stultz wrote:
> q6routing remoteproc-adsp:glink-edge:apr:apr-service@8:routing: ASoC:
> error at soc_component_read_no_lock on
> remoteproc-adsp:glink-edge:apr:: -5

This is an -EIO error which is reported when the ASoC component driver 
does not have both regmap and read callback and someone is trying to 
read a register!

In q6routing case all the dapm widgets reuse reg field in 
snd_soc_dapm_widget to store offset information or routing table indexs 
or some DSP related id and so on... These are not real registers.

I think the core is trying to read the state of these widgets during 
startup, Which will fail in qdsp6 case as we do not have any regmap or 
read callback associated with this ASoC component.

Previously we never had chance to see these messages so we did not 
implement any dummy read callback.

Adding a dummy callback to q6routing and q6afe-dai ASoC component will 
fix this issue at-least in Qualcomm case!

thanks,
srini