linux-kernel - Re: [GIT PULL] sound updates for 5.9

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200810175047.GH6438@sirena.org.uk>
Date:   Mon, 10 Aug 2020 18:50:47 +0100
From:   Mark Brown <broonie@...nel.org>
To:     Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
Cc:     John Stultz <john.stultz@...aro.org>, Takashi Iwai <tiwai@...e.de>,
        Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        Liam Girdwood <lgirdwood@...il.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Amit Pundir <amit.pundir@...aro.org>,
        Vinod Koul <vkoul@...nel.org>
Subject: Re: [GIT PULL] sound updates for 5.9

On Mon, Aug 10, 2020 at 06:06:14PM +0100, Srinivas Kandagatla wrote:

> In q6routing case all the dapm widgets reuse reg field in
> snd_soc_dapm_widget to store offset information or routing table indexs or
> some DSP related id and so on... These are not real registers.

> I think the core is trying to read the state of these widgets during
> startup, Which will fail in qdsp6 case as we do not have any regmap or read
> callback associated with this ASoC component.

Yes, it will try to figure out the current state of things during
startup.

> Previously we never had chance to see these messages so we did not implement
> any dummy read callback.

So I guess this is another instance of the issues with other things,
just having an effect beyond the cosmetic this time :/

> Adding a dummy callback to q6routing and q6afe-dai ASoC component will fix
> this issue at-least in Qualcomm case!

Yes, that's going to be better for robustness regardless of changes in
the core - just pick a default state if the underlying thing is
undefined.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)