lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <783b3e8a-40b1-379d-ae22-9b1fd9c50684@canonical.com>
Date:   Mon, 10 Aug 2020 18:26:16 +0100
From:   Colin Ian King <colin.king@...onical.com>
To:     Joe Perches <joe@...ches.com>,
        Alan Stern <stern@...land.harvard.edu>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-usb@...r.kernel.org, usb-storage@...ts.one-eyed-alien.net,
        kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] USB: storage: isd200: fix spelling mistake "removeable"
 -> "removable"

On 10/08/2020 18:14, Joe Perches wrote:
> On Mon, 2020-08-10 at 10:25 -0400, Alan Stern wrote:
>> On Mon, Aug 10, 2020 at 09:32:11AM +0100, Colin King wrote:
>>> From: Colin Ian King <colin.king@...onical.com>
>>>
>>> There is a spelling mistake in a usb_stor_dbg debug message. Fix it.
> 
> This is an alternate spelling in a few dictionaries.
> Is this an acceptable Briticism?
> If so, I suggest no change.

I was keeping it consistent with all the other occurrences of this word
in kernel messages.

> 
>>> diff --git a/drivers/usb/storage/isd200.c b/drivers/usb/storage/isd200.c
> []
>>> @@ -1383,7 +1383,7 @@ static int isd200_scsi_to_ata(struct scsi_cmnd *srb, struct us_data *us,
>>>  				ATA_CMD_MEDIA_LOCK : ATA_CMD_MEDIA_UNLOCK;
>>>  			isd200_srb_set_bufflen(srb, 0);
>>>  		} else {
>>> -			usb_stor_dbg(us, "   Not removeable media, just report okay\n");
>>> +			usb_stor_dbg(us, "   Not removable media, just report okay\n");
>>>  			srb->result = SAM_STAT_GOOD;
>>>  			sendToTransport = 0;
>>>  		}
>>> -- 
>>
>> Acked-by: Alan Stern <stern@...land.harvard.edu>
> 

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ