linux-kernel - Re: [PATCH 4.19 06/48] ALSA: seq: oss: Serialize ioctls

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200810172936.GA82601@kroah.com>
Date:   Mon, 10 Aug 2020 19:29:36 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Pavel Machek <pavel@...x.de>
Cc:     linux-kernel@...r.kernel.org, stable@...r.kernel.org,
        syzbot+1a54a94bd32716796edd@...kaller.appspotmail.com,
        syzbot+9d2abfef257f3e2d4713@...kaller.appspotmail.com,
        Hillf Danton <hdanton@...a.com>, Takashi Iwai <tiwai@...e.de>
Subject: Re: [PATCH 4.19 06/48] ALSA: seq: oss: Serialize ioctls

On Mon, Aug 10, 2020 at 06:37:17PM +0200, Pavel Machek wrote:
> Hi!
> 
> > commit 80982c7e834e5d4e325b6ce33757012ecafdf0bb upstream.
> > 
> > Some ioctls via OSS sequencer API may race and lead to UAF when the
> > port create and delete are performed concurrently, as spotted by a
> > couple of syzkaller cases.  This patch is an attempt to address it by
> > serializing the ioctls with the existing register_mutex.
> > 
> > Basically OSS sequencer API is an obsoleted interface and was designed
> > without much consideration of the concurrency.  There are very few
> > applications with it, and the concurrent performance isn't asked,
> > hence this "big hammer" approach should be good enough.
> 
> That really is a "big hammer". And I believe it is too big.

Please discuss code architecture decisions on the mailing list for the
subsystem/patch.  Doing it in random stable backports does not help out
as all of the developers involved are not copied here.

thanks,

greg k-h