[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <159718192589.1360974.15808376172581486987@swboyd.mtv.corp.google.com>
Date: Tue, 11 Aug 2020 14:38:45 -0700
From: Stephen Boyd <swboyd@...omium.org>
To: Sibi Sankar <sibis@...eaurora.org>, bjorn.andersson@...aro.org,
rjw@...ysocki.net, ulf.hansson@...aro.org
Cc: agross@...nel.org, linux-kernel@...r.kernel.org,
linux-arm-msm@...r.kernel.org, linux-pm@...r.kernel.org,
gregkh@...uxfoundation.org, pavel@....cz, len.brown@...el.com,
rnayak@...eaurora.org, dianders@...omium.org, khilman@...nel.org,
Sibi Sankar <sibis@...eaurora.org>
Subject: Re: [PATCH 1/2] PM / Domains: Add GENPD_FLAG_SUSPEND_ON flag
Quoting Sibi Sankar (2020-08-11 12:02:51)
> diff --git a/include/linux/pm_domain.h b/include/linux/pm_domain.h
> index ee11502a575b0..3002a2d68936a 100644
> --- a/include/linux/pm_domain.h
> +++ b/include/linux/pm_domain.h
> @@ -55,6 +55,10 @@
> *
> * GENPD_FLAG_RPM_ALWAYS_ON: Instructs genpd to always keep the PM domain
> * powered on except for system suspend.
> + *
> + * GENPD_FLAG_SUSPEND_ON: Instructs genpd to keep the PM domain powered
> + * on during suspend and runtime PM controlled
Maybe, "powered on across system suspend (if it is already powered on)"
to match the hunk above that talks about system suspend for
GENPD_FLAG_RPM_ALWAYS_ON. Otherwise someone may think that this powers
on the genpd during suspend or powers it on during runtime suspend.
> + * otherwise.
> */
> #define GENPD_FLAG_PM_CLK (1U << 0)
> #define GENPD_FLAG_IRQ_SAFE (1U << 1)
Powered by blists - more mailing lists