linux-kernel - Re: [PATCH 19/20] media: platform: vpdma.c: fix comparison to bool

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200811125748.s3pdpwjmqmd5bffb@ti.com>
Date:   Tue, 11 Aug 2020 07:57:48 -0500
From:   Benoit Parrot <bparrot@...com>
To:     "Daniel W. S. Almeida" <dwlsalmeida@...il.com>
CC:     <skhan@...uxfoundation.org>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        <linux-media@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 19/20] media: platform: vpdma.c: fix comparison to bool

Daniel W. S. Almeida <dwlsalmeida@...il.com> wrote on Fri [2020-Aug-07 05:35:46 -0300]:
> From: "Daniel W. S. Almeida" <dwlsalmeida@...il.com>
> 
> Fix the following coccinelle report:
> 
> drivers/media/platform/ti-vpe/vpdma.c:946:5-26: WARNING:
> Comparison to bool
> 
> Found using - Coccinelle (http://coccinelle.lip6.fr)
> 
> Signed-off-by: Daniel W. S. Almeida <dwlsalmeida@...il.com>

Reviewed-by: Benoit Parrot <bparrot@...com>

> ---
>  drivers/media/platform/ti-vpe/vpdma.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/media/platform/ti-vpe/vpdma.c b/drivers/media/platform/ti-vpe/vpdma.c
> index 2e5148ae7a0f..de600ffffbbc 100644
> --- a/drivers/media/platform/ti-vpe/vpdma.c
> +++ b/drivers/media/platform/ti-vpe/vpdma.c
> @@ -943,7 +943,7 @@ int vpdma_hwlist_alloc(struct vpdma_data *vpdma, void *priv)
>  
>  	spin_lock_irqsave(&vpdma->lock, flags);
>  	for (i = 0; i < VPDMA_MAX_NUM_LIST &&
> -	    vpdma->hwlist_used[i] == true; i++)
> +	    vpdma->hwlist_used[i]; i++)
>  		;
>  
>  	if (i < VPDMA_MAX_NUM_LIST) {
> -- 
> 2.28.0
>