linux-kernel - Re: [PATCH 19/20] media: platform: vpdma.c: fix comparison to bool

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5dd3d10088dbc8a126bc788237f5206130a090ae.camel@perches.com>
Date:   Tue, 11 Aug 2020 11:34:09 -0700
From:   Joe Perches <joe@...ches.com>
To:     Benoit Parrot <bparrot@...com>,
        "Daniel W. S. Almeida" <dwlsalmeida@...il.com>
Cc:     skhan@...uxfoundation.org,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        linux-media@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 19/20] media: platform: vpdma.c: fix comparison to bool

On Tue, 2020-08-11 at 07:57 -0500, Benoit Parrot wrote:
> Daniel W. S. Almeida <dwlsalmeida@...il.com> wrote on Fri [2020-Aug-07 05:35:46 -0300]:
> > From: "Daniel W. S. Almeida" <dwlsalmeida@...il.com>
> > 
> > Fix the following coccinelle report:
> > 
> > drivers/media/platform/ti-vpe/vpdma.c:946:5-26: WARNING:
> > Comparison to bool
> > 
> > Found using - Coccinelle (http://coccinelle.lip6.fr)
[]
> > diff --git a/drivers/media/platform/ti-vpe/vpdma.c b/drivers/media/platform/ti-vpe/vpdma.c
[]
> > @@ -943,7 +943,7 @@ int vpdma_hwlist_alloc(struct vpdma_data *vpdma, void *priv)
> >  
> >  	spin_lock_irqsave(&vpdma->lock, flags);
> >  	for (i = 0; i < VPDMA_MAX_NUM_LIST &&
> > -	    vpdma->hwlist_used[i] == true; i++)
> > +	    vpdma->hwlist_used[i]; i++)
> >  		;


A more typical way to write this loop is
not testing i < VPDMA_MAX_NUM_LIST multiple
times like the below:
---
 drivers/media/platform/ti-vpe/vpdma.c | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/drivers/media/platform/ti-vpe/vpdma.c b/drivers/media/platform/ti-vpe/vpdma.c
index 2e5148ae7a0f..5893917ce50d 100644
--- a/drivers/media/platform/ti-vpe/vpdma.c
+++ b/drivers/media/platform/ti-vpe/vpdma.c
@@ -942,14 +942,13 @@ int vpdma_hwlist_alloc(struct vpdma_data *vpdma, void *priv)
 	unsigned long flags;
 
 	spin_lock_irqsave(&vpdma->lock, flags);
-	for (i = 0; i < VPDMA_MAX_NUM_LIST &&
-	    vpdma->hwlist_used[i] == true; i++)
-		;
-
-	if (i < VPDMA_MAX_NUM_LIST) {
+	for (i = 0; i < VPDMA_MAX_NUM_LIST; i++) {
+		if (vpdma->hwlist_used[i])
+			continue;
 		list_num = i;
 		vpdma->hwlist_used[i] = true;
 		vpdma->hwlist_priv[i] = priv;
+		break;
 	}
 	spin_unlock_irqrestore(&vpdma->lock, flags);