linux-kernel - Re: [PATCH] usb: gadget: tegra-xudc: Avoid GFP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f29c7d35-72a9-b8d1-98dc-427c6fa3cc31@nvidia.com>
Date:   Tue, 11 Aug 2020 09:18:35 +0800
From:   JC Kuo <jckuo@...dia.com>
To:     Thierry Reding <thierry.reding@...il.com>,
        Christophe JAILLET <christophe.jaillet@...adoo.fr>,
        Nagarjuna Kristam <nkristam@...dia.com>
CC:     <balbi@...nel.org>, <gregkh@...uxfoundation.org>,
        <jonathanh@...dia.com>, <yuehaibing@...wei.com>,
        <heikki.krogerus@...ux.intel.com>, <linux-usb@...r.kernel.org>,
        <linux-tegra@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <kernel-janitors@...r.kernel.org>
Subject: Re: [PATCH] usb: gadget: tegra-xudc: Avoid GFP_ATOMIC where it is not
 needed

Looks good to me.

Reviewed-by: JC Kuo <jckuo@...dia.com>

On 8/10/20 10:00 PM, Thierry Reding wrote:
> On Sun, Aug 09, 2020 at 09:29:48AM +0200, Christophe JAILLET wrote:
>> There is no need to use GFP_ATOMIC here. It is a probe function, no
>> spinlock is taken.
>>
>> Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>
>> ---
>>  drivers/usb/gadget/udc/tegra-xudc.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
> Looks good to me. I can't think of any reason why this would have to be
> an atomic allocation. Nagarjuna, please shout if this is really needed,
> otherwise:
>
> Acked-by: Thierry Reding <treding@...dia.com>