linux-kernel - Re: [PATCH] selftests: Add VRF icmp error route lookup test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f43a9397-c506-9270-b423-efaf6f520a80@gmail.com>
Date:   Tue, 11 Aug 2020 12:57:35 -0600
From:   David Ahern <dsahern@...il.com>
To:     David Miller <davem@...emloft.net>, mjeanson@...icios.com
Cc:     dsahern@...nel.org, linux-kernel@...r.kernel.org,
        mathieu.desnoyers@...icios.com, netdev@...r.kernel.org
Subject: Re: [PATCH] selftests: Add VRF icmp error route lookup test

On 8/11/20 11:28 AM, David Miller wrote:
> From: Michael Jeanson <mjeanson@...icios.com>
> Date: Thu,  6 Aug 2020 14:51:21 -0400
> 
>> The objective is to check that the incoming vrf routing table is selected
>> to send an ICMP error back to the source when the ttl of a packet reaches 1
>> while it is forwarded between different vrfs.
>>
>> The first test sends a ping with a ttl of 1 from h1 to h2 and parses the
>> output of the command to check that a ttl expired error is received.
>>
>> [This may be flaky, I'm open to suggestions of a more robust approch.]
>>
>> The second test runs traceroute from h1 to h2 and parses the output to
>> check for a hop on r1.
>>
>> Signed-off-by: Michael Jeanson <mjeanson@...icios.com>
> 
> This patch does not apply cleanly to the current net tree.
> 

It is also out of context since the tests fail on current net and net-next.

The tests along with the patches that fix the problem should be sent
together.